[PATCH] drivers: extcon: space required after that ','

hanyu001@208suo.com posted 1 patch 2 years, 6 months ago
drivers/extcon/extcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] drivers: extcon: space required after that ','
Posted by hanyu001@208suo.com 2 years, 6 months ago
This patch fixes the checkpatch.pl error:

./drivers/extcon/extcon.c:321: ERROR: space required after that ',' 
(ctx:VxV)

Signed-off-by: maqimei <2433033762@qq.com>
---
  drivers/extcon/extcon.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 6f7a60d..4ef4422 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned 
int id, unsigned int prop)
  }

  static int is_extcon_property_capability(struct extcon_dev *edev,
-                unsigned int id, int index,unsigned int prop)
+                unsigned int id, int index, unsigned int prop)
  {
      struct extcon_cable *cable;
      int type, ret;
Re: [PATCH] drivers: extcon: space required after that ','
Posted by Chanwoo Choi 2 years, 6 months ago
Hi,

On 23. 7. 17. 18:03, hanyu001@208suo.com wrote:
> This patch fixes the checkpatch.pl error:
> 
> ./drivers/extcon/extcon.c:321: ERROR: space required after that ',' (ctx:VxV)
> 
> Signed-off-by: maqimei <2433033762@qq.com>

'maqimei' is your name? 

I recommend that you can check the guide of 'submitting-patches'[1].
[1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

Please update your name.

> ---
>  drivers/extcon/extcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 6f7a60d..4ef4422 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned int id, unsigned int prop)
>  }
> 
>  static int is_extcon_property_capability(struct extcon_dev *edev,
> -                unsigned int id, int index,unsigned int prop)
> +                unsigned int id, int index, unsigned int prop)
>  {
>      struct extcon_cable *cable;
>      int type, ret;

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi

RE: [PATCH] drivers: extcon: space required after that ','
Posted by MyungJoo Ham 2 years, 6 months ago
>This patch fixes the checkpatch.pl error:
>
>./drivers/extcon/extcon.c:321: ERROR: space required after that ',' 
>(ctx:VxV)
>
>Signed-off-by: maqimei <2433033762@qq.com>

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

@Chanwoo, it looks like that's from a 7 years old commit of yours :).

>---
>  drivers/extcon/extcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
>index 6f7a60d..4ef4422 100644
>--- a/drivers/extcon/extcon.c
>+++ b/drivers/extcon/extcon.c
>@@ -318,7 +318,7 @@ static bool is_extcon_property_supported(unsigned 
>int id, unsigned int prop)
>  }
>
>  static int is_extcon_property_capability(struct extcon_dev *edev,
>-                unsigned int id, int index,unsigned int prop)
>+                unsigned int id, int index, unsigned int prop)
>  {
>      struct extcon_cable *cable;
>      int type, ret;