serial: 8250: SERIAL_8250_ASPEED_VUART should depend on ARCH_ASPEED

[PATCH] serial: 8250: SERIAL_8250_ASPEED_VUART should depend on ARCH_ASPEED

Posted by Geert Uytterhoeven 3 years, 9 months ago

The Aspeed Virtual UART is only present on Aspeed BMC platforms.  Hence
add a dependency on ARCH_ASPEED, to prevent asking the user about this
driver when configuring a kernel without Aspeed BMC support.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/tty/serial/8250/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index c621c21db7863278..6c1d2e70e497a19a 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -254,6 +254,7 @@ config SERIAL_8250_ASPEED_VUART
 	depends on SERIAL_8250
 	depends on OF
 	depends on REGMAP && MFD_SYSCON
+	depends on ARCH_ASPEED || COMPILE_TEST
 	help
 	  If you want to use the virtual UART (VUART) device on Aspeed
 	  BMC platforms, enable this option. This enables the 16550A-
-- 
2.25.1

Re: [PATCH] serial: 8250: SERIAL_8250_ASPEED_VUART should depend on ARCH_ASPEED

Posted by Jeremy Kerr 3 years, 9 months ago

Hi Geert,

> The Aspeed Virtual UART is only present on Aspeed BMC platforms. 
> Hence add a dependency on ARCH_ASPEED, to prevent asking the user
> about this driver when configuring a kernel without Aspeed BMC
> support.

All fine by me. It'd be super weird if this hardware appeared on a
non-ASPEED platform.

Reviewed-by: Jeremy Kerr <jk@ozlabs.org>

Cheers,


Jeremy