[PATCH v4 2/2] ACPI: glue: Rework the success message in acpi_device_notify()

Rafael J. Wysocki posted 1 patch 2 weeks, 5 days ago
drivers/acpi/glue.c |    3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH v4 2/2] ACPI: glue: Rework the success message in acpi_device_notify()
Posted by Rafael J. Wysocki 2 weeks, 5 days ago
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>

Using an ACPI handle in the acpi_device_notify() success message is
somewhat misleading because the "physical" device is not bound to an
ACPI namespace object in that function, but to an ACPI device object
attached to it.  Moreover, the message is outright confusing for the
"physical" devices bound to ACPI devices without ACPI namespace
objects (for example, fixed event buttons).

Address this by turning that message into a dev_dbg() one printed for
the "physical" device and mentioning the name of the ACPI companion.

Fixes: ab06eb920401 ("ACPI: scan: Register platform devices for fixed event buttons")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/glue.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/acpi/glue.c
+++ b/drivers/acpi/glue.c
@@ -394,8 +394,7 @@ void acpi_device_notify(struct device *d
 		adev->handler->bind(dev);
 
 done:
-	acpi_handle_debug(ACPI_HANDLE(dev), "Bound to device %s\n",
-			  dev_name(dev));
+	dev_dbg(dev, "Bound to ACPI device %s\n", acpi_dev_name(adev));
 }
 
 void acpi_device_notify_remove(struct device *dev)
Re: [PATCH v4 2/2] ACPI: glue: Rework the success message in acpi_device_notify()
Posted by Andy Shevchenko 2 weeks, 3 days ago
On Sun, Sep 06, 2026 at 05:54:10PM +0200, Rafael J. Wysocki wrote:

> Using an ACPI handle in the acpi_device_notify() success message is
> somewhat misleading because the "physical" device is not bound to an
> ACPI namespace object in that function, but to an ACPI device object
> attached to it.  Moreover, the message is outright confusing for the
> "physical" devices bound to ACPI devices without ACPI namespace
> objects (for example, fixed event buttons).
> 
> Address this by turning that message into a dev_dbg() one printed for
> the "physical" device and mentioning the name of the ACPI companion.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko