[PATCH v1 3/3] thermal: core: Rename function argument related to trip crossing

Posted by Rafael J. Wysocki 1 year ago

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Rename the 'crossed_up' function argument to 'upward', which is more
proper English and a better match for representing temperature change
direction, everywhere in the code.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/thermal/gov_bang_bang.c  |    6 +++---
 drivers/thermal/gov_user_space.c |    4 ++--
 drivers/thermal/thermal_core.c   |   10 +++++-----
 drivers/thermal/thermal_core.h   |    2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

--- a/drivers/thermal/gov_bang_bang.c
+++ b/drivers/thermal/gov_bang_bang.c
@@ -58,11 +58,11 @@
  * bang_bang_trip_crossed - controls devices associated with the given zone
  * @tz: thermal_zone_device
  * @trip: the trip point
- * @crossed_up: whether or not the trip has been crossed on the way up
+ * @upward: whether or not the trip has been crossed on the way up
  */
 static void bang_bang_trip_crossed(struct thermal_zone_device *tz,
 				   const struct thermal_trip *trip,
-				   bool crossed_up)
+				   bool upward)
 {
 	const struct thermal_trip_desc *td = trip_to_trip_desc(trip);
 	struct thermal_instance *instance;
@@ -74,7 +74,7 @@
 		tz->temperature, trip->hysteresis);
 
 	list_for_each_entry(instance, &td->thermal_instances, trip_node)
-		bang_bang_set_instance_target(instance, crossed_up);
+		bang_bang_set_instance_target(instance, upward);
 }
 
 static void bang_bang_manage(struct thermal_zone_device *tz)
--- a/drivers/thermal/gov_user_space.c
+++ b/drivers/thermal/gov_user_space.c
@@ -26,13 +26,13 @@
  * user_space_trip_crossed - Notify user space about trip crossing events
  * @tz: thermal_zone_device
  * @trip: trip point
- * @crossed_up: whether or not the trip has been crossed on the way up
+ * @upward: whether or not the trip has been crossed on the way up
  *
  * This function notifies the user space through UEvents.
  */
 static void user_space_trip_crossed(struct thermal_zone_device *tz,
 				    const struct thermal_trip *trip,
-				    bool crossed_up)
+				    bool upward)
 {
 	char *thermal_prop[5];
 	int i;
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -454,23 +454,23 @@
 static void thermal_governor_trip_crossed(struct thermal_governor *governor,
 					  struct thermal_zone_device *tz,
 					  const struct thermal_trip *trip,
-					  bool crossed_up)
+					  bool upward)
 {
 	if (trip->type == THERMAL_TRIP_HOT || trip->type == THERMAL_TRIP_CRITICAL)
 		return;
 
 	if (governor->trip_crossed)
-		governor->trip_crossed(tz, trip, crossed_up);
+		governor->trip_crossed(tz, trip, upward);
 }
 
 static void thermal_trip_crossed(struct thermal_zone_device *tz,
 				 struct thermal_trip_desc *td,
 				 struct thermal_governor *governor,
-				 bool crossed_up)
+				 bool upward)
 {
 	const struct thermal_trip *trip = &td->trip;
 
-	if (crossed_up) {
+	if (upward) {
 		if (trip->type == THERMAL_TRIP_PASSIVE)
 			tz->passive++;
 		else if (trip->type == THERMAL_TRIP_CRITICAL ||
@@ -493,7 +493,7 @@
 		dev_info(&tz->device, "Trip crossed down: %d\n",
 			 trip->temperature - trip->hysteresis);
 	}
-	thermal_governor_trip_crossed(governor, tz, trip, crossed_up);
+	thermal_governor_trip_crossed(governor, tz, trip, upward);
 }
 
 void thermal_zone_set_trip_hyst(struct thermal_zone_device *tz,
--- a/drivers/thermal/thermal_core.h
+++ b/drivers/thermal/thermal_core.h
@@ -56,7 +56,7 @@
 	void (*unbind_from_tz)(struct thermal_zone_device *tz);
 	void (*trip_crossed)(struct thermal_zone_device *tz,
 			     const struct thermal_trip *trip,
-			     bool crossed_up);
+			     bool upward);
 	void (*manage)(struct thermal_zone_device *tz);
 	void (*update_tz)(struct thermal_zone_device *tz,
 			  enum thermal_notify_event reason);

Re: [PATCH v1 3/3] thermal: core: Rename function argument related to trip crossing

Posted by Lukasz Luba 1 year ago


On 1/16/25 19:31, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Rename the 'crossed_up' function argument to 'upward', which is more
> proper English and a better match for representing temperature change
> direction, everywhere in the code.
> 
> No functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>   drivers/thermal/gov_bang_bang.c  |    6 +++---
>   drivers/thermal/gov_user_space.c |    4 ++--
>   drivers/thermal/thermal_core.c   |   10 +++++-----
>   drivers/thermal/thermal_core.h   |    2 +-
>   4 files changed, 11 insertions(+), 11 deletions(-)
> 
> --- a/drivers/thermal/gov_bang_bang.c
> +++ b/drivers/thermal/gov_bang_bang.c
> @@ -58,11 +58,11 @@
>    * bang_bang_trip_crossed - controls devices associated with the given zone
>    * @tz: thermal_zone_device
>    * @trip: the trip point
> - * @crossed_up: whether or not the trip has been crossed on the way up
> + * @upward: whether or not the trip has been crossed on the way up
>    */
>   static void bang_bang_trip_crossed(struct thermal_zone_device *tz,
>   				   const struct thermal_trip *trip,
> -				   bool crossed_up)
> +				   bool upward)
>   {
>   	const struct thermal_trip_desc *td = trip_to_trip_desc(trip);
>   	struct thermal_instance *instance;
> @@ -74,7 +74,7 @@
>   		tz->temperature, trip->hysteresis);
>   
>   	list_for_each_entry(instance, &td->thermal_instances, trip_node)
> -		bang_bang_set_instance_target(instance, crossed_up);
> +		bang_bang_set_instance_target(instance, upward);
>   }
>   
>   static void bang_bang_manage(struct thermal_zone_device *tz)
> --- a/drivers/thermal/gov_user_space.c
> +++ b/drivers/thermal/gov_user_space.c
> @@ -26,13 +26,13 @@
>    * user_space_trip_crossed - Notify user space about trip crossing events
>    * @tz: thermal_zone_device
>    * @trip: trip point
> - * @crossed_up: whether or not the trip has been crossed on the way up
> + * @upward: whether or not the trip has been crossed on the way up
>    *
>    * This function notifies the user space through UEvents.
>    */
>   static void user_space_trip_crossed(struct thermal_zone_device *tz,
>   				    const struct thermal_trip *trip,
> -				    bool crossed_up)
> +				    bool upward)
>   {
>   	char *thermal_prop[5];
>   	int i;
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -454,23 +454,23 @@
>   static void thermal_governor_trip_crossed(struct thermal_governor *governor,
>   					  struct thermal_zone_device *tz,
>   					  const struct thermal_trip *trip,
> -					  bool crossed_up)
> +					  bool upward)
>   {
>   	if (trip->type == THERMAL_TRIP_HOT || trip->type == THERMAL_TRIP_CRITICAL)
>   		return;
>   
>   	if (governor->trip_crossed)
> -		governor->trip_crossed(tz, trip, crossed_up);
> +		governor->trip_crossed(tz, trip, upward);
>   }
>   
>   static void thermal_trip_crossed(struct thermal_zone_device *tz,
>   				 struct thermal_trip_desc *td,
>   				 struct thermal_governor *governor,
> -				 bool crossed_up)
> +				 bool upward)
>   {
>   	const struct thermal_trip *trip = &td->trip;
>   
> -	if (crossed_up) {
> +	if (upward) {
>   		if (trip->type == THERMAL_TRIP_PASSIVE)
>   			tz->passive++;
>   		else if (trip->type == THERMAL_TRIP_CRITICAL ||
> @@ -493,7 +493,7 @@
>   		dev_info(&tz->device, "Trip crossed down: %d\n",
>   			 trip->temperature - trip->hysteresis);
>   	}
> -	thermal_governor_trip_crossed(governor, tz, trip, crossed_up);
> +	thermal_governor_trip_crossed(governor, tz, trip, upward);
>   }
>   
>   void thermal_zone_set_trip_hyst(struct thermal_zone_device *tz,
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -56,7 +56,7 @@
>   	void (*unbind_from_tz)(struct thermal_zone_device *tz);
>   	void (*trip_crossed)(struct thermal_zone_device *tz,
>   			     const struct thermal_trip *trip,
> -			     bool crossed_up);
> +			     bool upward);
>   	void (*manage)(struct thermal_zone_device *tz);
>   	void (*update_tz)(struct thermal_zone_device *tz,
>   			  enum thermal_notify_event reason);
> 
> 
> 


Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>