[PATCH] ssb: Clean up errors in ssb_driver_gige.h

chenguohua@jari.cn posted 1 patch 2 years, 2 months ago
include/linux/ssb/ssb_driver_gige.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] ssb: Clean up errors in ssb_driver_gige.h
Posted by chenguohua@jari.cn 2 years, 2 months ago
Fix the following errors reported by checkpatch:

ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>
---
 include/linux/ssb/ssb_driver_gige.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/ssb/ssb_driver_gige.h b/include/linux/ssb/ssb_driver_gige.h
index 28c145a51e57..55c0bb39a410 100644
--- a/include/linux/ssb/ssb_driver_gige.h
+++ b/include/linux/ssb/ssb_driver_gige.h
@@ -55,7 +55,7 @@ struct ssb_gige {
 extern bool pdev_is_ssb_gige_core(struct pci_dev *pdev);
 
 /* Convert a pci_dev pointer to a ssb_gige pointer. */
-static inline struct ssb_gige * pdev_to_ssb_gige(struct pci_dev *pdev)
+static inline struct ssb_gige *pdev_to_ssb_gige(struct pci_dev *pdev)
 {
 	if (!pdev_is_ssb_gige_core(pdev))
 		return NULL;
@@ -66,7 +66,7 @@ static inline struct ssb_gige * pdev_to_ssb_gige(struct pci_dev *pdev)
 static inline bool ssb_gige_is_rgmii(struct pci_dev *pdev)
 {
 	struct ssb_gige *dev = pdev_to_ssb_gige(pdev);
-	return (dev ? dev->has_rgmii : 0);
+	return dev ? dev->has_rgmii : 0;
 }
 
 /* Returns whether we have a Roboswitch. */
@@ -161,7 +161,7 @@ static inline bool pdev_is_ssb_gige_core(struct pci_dev *pdev)
 {
 	return false;
 }
-static inline struct ssb_gige * pdev_to_ssb_gige(struct pci_dev *pdev)
+static inline struct ssb_gige *pdev_to_ssb_gige(struct pci_dev *pdev)
 {
 	return NULL;
 }
-- 
2.17.1
Re: [PATCH] ssb: Clean up errors in ssb_driver_gige.h
Posted by Kalle Valo 2 years, 1 month ago
chenguohua@jari.cn wrote:

> Fix the following errors reported by checkpatch:
> 
> ERROR: "foo * bar" should be "foo *bar"
> 
> Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>

We prefer not to take checkpatch fixes unless explicitly requested by
the maintainers.

Patch set to Rejected.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/23127c9a.945.18b270aa249.Coremail.chenguohua@jari.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches