[PATCH v2 00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit

Rafael J. Wysocki posted 12 patches 1 month, 3 weeks ago
[PATCH v2 00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit
Posted by Rafael J. Wysocki 1 month, 3 weeks ago
Hi Everyone,

After posting the two series of thermal core patches for 6.13:

https://lore.kernel.org/linux-pm/4920970.GXAFRqVoOG@rjwysocki.net/

and

https://lore.kernel.org/linux-pm/6100907.lOV4Wx5bFT@rjwysocki.net/

before the 6.12 merge window, I have decided to reorder the changes included in
these series, so that fixes and more significant cleanups (for example, changing
they layout of data structures) go first, followed by the changes related to
using guards for locking, and the optimization involving sorted lists becomes
the last piece.

This series is the first part and the majority of patches in it come from the
second (RFC) series mentioned above.  Of course, they needed to be rebased to
be applied in the new order.  It is on top of 6.12-rc1 with

https://lore.kernel.org/linux-pm/12549318.O9o76ZdvQC@rjwysocki.net/

applied and it will be added to my thermal-core-testing branch.  It is in v2
to start with because all of the patches in it have already been posted in
some form.

The first 10 patches fix some potential issues related to thermal zone
initialization and exit (for example, user space may start to interact with
a thermal zone during its initialization before it's ready and system suspend
taking place at a wrong time may skip a new thermal zone so it is not suspended)
and do some cleanups related to that.  This concludes with the removal of the
need_update field from struct thermal_zone_device.

The last two patches move lists of thermal instances from thermal zones to
trip point descriptors and clean up some code on top of that.

Please refer to the individual patch changelogs for details.

Thanks!
Re: [PATCH v2 00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit
Posted by Rafael J. Wysocki 1 month, 2 weeks ago
On Fri, Oct 4, 2024 at 10:11 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> Hi Everyone,
>
> After posting the two series of thermal core patches for 6.13:
>
> https://lore.kernel.org/linux-pm/4920970.GXAFRqVoOG@rjwysocki.net/
>
> and
>
> https://lore.kernel.org/linux-pm/6100907.lOV4Wx5bFT@rjwysocki.net/
>
> before the 6.12 merge window, I have decided to reorder the changes included in
> these series, so that fixes and more significant cleanups (for example, changing
> they layout of data structures) go first, followed by the changes related to
> using guards for locking, and the optimization involving sorted lists becomes
> the last piece.
>
> This series is the first part and the majority of patches in it come from the
> second (RFC) series mentioned above.  Of course, they needed to be rebased to
> be applied in the new order.  It is on top of 6.12-rc1 with
>
> https://lore.kernel.org/linux-pm/12549318.O9o76ZdvQC@rjwysocki.net/
>
> applied and it will be added to my thermal-core-testing branch.  It is in v2
> to start with because all of the patches in it have already been posted in
> some form.
>
> The first 10 patches fix some potential issues related to thermal zone
> initialization and exit (for example, user space may start to interact with
> a thermal zone during its initialization before it's ready and system suspend
> taking place at a wrong time may skip a new thermal zone so it is not suspended)
> and do some cleanups related to that.  This concludes with the removal of the
> need_update field from struct thermal_zone_device.
>
> The last two patches move lists of thermal instances from thermal zones to
> trip point descriptors and clean up some code on top of that.
>
> Please refer to the individual patch changelogs for details.

This material is now present in the thermal-core-testing and
thermal-core-experimental branches in linux-pm.git.
Re: [PATCH v2 00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit
Posted by Rafael J. Wysocki 1 month, 1 week ago
On Fri, Oct 11, 2024 at 8:50 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Fri, Oct 4, 2024 at 10:11 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >
> > Hi Everyone,
> >
> > After posting the two series of thermal core patches for 6.13:
> >
> > https://lore.kernel.org/linux-pm/4920970.GXAFRqVoOG@rjwysocki.net/
> >
> > and
> >
> > https://lore.kernel.org/linux-pm/6100907.lOV4Wx5bFT@rjwysocki.net/
> >
> > before the 6.12 merge window, I have decided to reorder the changes included in
> > these series, so that fixes and more significant cleanups (for example, changing
> > they layout of data structures) go first, followed by the changes related to
> > using guards for locking, and the optimization involving sorted lists becomes
> > the last piece.
> >
> > This series is the first part and the majority of patches in it come from the
> > second (RFC) series mentioned above.  Of course, they needed to be rebased to
> > be applied in the new order.  It is on top of 6.12-rc1 with
> >
> > https://lore.kernel.org/linux-pm/12549318.O9o76ZdvQC@rjwysocki.net/
> >
> > applied and it will be added to my thermal-core-testing branch.  It is in v2
> > to start with because all of the patches in it have already been posted in
> > some form.
> >
> > The first 10 patches fix some potential issues related to thermal zone
> > initialization and exit (for example, user space may start to interact with
> > a thermal zone during its initialization before it's ready and system suspend
> > taking place at a wrong time may skip a new thermal zone so it is not suspended)
> > and do some cleanups related to that.  This concludes with the removal of the
> > need_update field from struct thermal_zone_device.
> >
> > The last two patches move lists of thermal instances from thermal zones to
> > trip point descriptors and clean up some code on top of that.
> >
> > Please refer to the individual patch changelogs for details.
>
> This material is now present in the thermal-core-testing and
> thermal-core-experimental branches in linux-pm.git.

I gather that it is not controversial and it has been around for quite
a while, and it was discussed during the PM+TC session at the LPC, so
I've just applied it for 6.13.
Re: [PATCH v2 00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit
Posted by Lukasz Luba 1 month, 1 week ago
Hi Rafael,

On 10/21/24 12:05, Rafael J. Wysocki wrote:
> On Fri, Oct 11, 2024 at 8:50 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>>
>> On Fri, Oct 4, 2024 at 10:11 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>>>
>>> Hi Everyone,
>>>
>>> After posting the two series of thermal core patches for 6.13:
>>>
>>> https://lore.kernel.org/linux-pm/4920970.GXAFRqVoOG@rjwysocki.net/
>>>
>>> and
>>>
>>> https://lore.kernel.org/linux-pm/6100907.lOV4Wx5bFT@rjwysocki.net/
>>>
>>> before the 6.12 merge window, I have decided to reorder the changes included in
>>> these series, so that fixes and more significant cleanups (for example, changing
>>> they layout of data structures) go first, followed by the changes related to
>>> using guards for locking, and the optimization involving sorted lists becomes
>>> the last piece.
>>>
>>> This series is the first part and the majority of patches in it come from the
>>> second (RFC) series mentioned above.  Of course, they needed to be rebased to
>>> be applied in the new order.  It is on top of 6.12-rc1 with
>>>
>>> https://lore.kernel.org/linux-pm/12549318.O9o76ZdvQC@rjwysocki.net/
>>>
>>> applied and it will be added to my thermal-core-testing branch.  It is in v2
>>> to start with because all of the patches in it have already been posted in
>>> some form.
>>>
>>> The first 10 patches fix some potential issues related to thermal zone
>>> initialization and exit (for example, user space may start to interact with
>>> a thermal zone during its initialization before it's ready and system suspend
>>> taking place at a wrong time may skip a new thermal zone so it is not suspended)
>>> and do some cleanups related to that.  This concludes with the removal of the
>>> need_update field from struct thermal_zone_device.
>>>
>>> The last two patches move lists of thermal instances from thermal zones to
>>> trip point descriptors and clean up some code on top of that.
>>>
>>> Please refer to the individual patch changelogs for details.
>>
>> This material is now present in the thermal-core-testing and
>> thermal-core-experimental branches in linux-pm.git.
> 
> I gather that it is not controversial and it has been around for quite
> a while, and it was discussed during the PM+TC session at the LPC, so
> I've just applied it for 6.13.

I hope it wasn't too late. The patch set looks good and I have
added my reviewed tags.

Regards,
Lukasz
Re: [PATCH v2 00/12] thermal: core: Fixes and cleanups, mostly related to thermal zone init and exit
Posted by Rafael J. Wysocki 1 month ago
Hi Lukasz,

On Tue, Oct 22, 2024 at 12:44 AM Lukasz Luba <lukasz.luba@arm.com> wrote:
>
> Hi Rafael,
>
> On 10/21/24 12:05, Rafael J. Wysocki wrote:
> > On Fri, Oct 11, 2024 at 8:50 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >>
> >> On Fri, Oct 4, 2024 at 10:11 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >>>
> >>> Hi Everyone,
> >>>
> >>> After posting the two series of thermal core patches for 6.13:
> >>>
> >>> https://lore.kernel.org/linux-pm/4920970.GXAFRqVoOG@rjwysocki.net/
> >>>
> >>> and
> >>>
> >>> https://lore.kernel.org/linux-pm/6100907.lOV4Wx5bFT@rjwysocki.net/
> >>>
> >>> before the 6.12 merge window, I have decided to reorder the changes included in
> >>> these series, so that fixes and more significant cleanups (for example, changing
> >>> they layout of data structures) go first, followed by the changes related to
> >>> using guards for locking, and the optimization involving sorted lists becomes
> >>> the last piece.
> >>>
> >>> This series is the first part and the majority of patches in it come from the
> >>> second (RFC) series mentioned above.  Of course, they needed to be rebased to
> >>> be applied in the new order.  It is on top of 6.12-rc1 with
> >>>
> >>> https://lore.kernel.org/linux-pm/12549318.O9o76ZdvQC@rjwysocki.net/
> >>>
> >>> applied and it will be added to my thermal-core-testing branch.  It is in v2
> >>> to start with because all of the patches in it have already been posted in
> >>> some form.
> >>>
> >>> The first 10 patches fix some potential issues related to thermal zone
> >>> initialization and exit (for example, user space may start to interact with
> >>> a thermal zone during its initialization before it's ready and system suspend
> >>> taking place at a wrong time may skip a new thermal zone so it is not suspended)
> >>> and do some cleanups related to that.  This concludes with the removal of the
> >>> need_update field from struct thermal_zone_device.
> >>>
> >>> The last two patches move lists of thermal instances from thermal zones to
> >>> trip point descriptors and clean up some code on top of that.
> >>>
> >>> Please refer to the individual patch changelogs for details.
> >>
> >> This material is now present in the thermal-core-testing and
> >> thermal-core-experimental branches in linux-pm.git.
> >
> > I gather that it is not controversial and it has been around for quite
> > a while, and it was discussed during the PM+TC session at the LPC, so
> > I've just applied it for 6.13.
>
> I hope it wasn't too late. The patch set looks good and I have
> added my reviewed tags.

No, it wasn't, thank you!