[PATCH] drm/radeon/dpm: ERROR: open brace '{' following enum go on the same line

shijie001@208suo.com posted 1 patch 2 years, 6 months ago
drivers/gpu/drm/radeon/ni_dpm.h | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
[PATCH] drm/radeon/dpm: ERROR: open brace '{' following enum go on the same line
Posted by shijie001@208suo.com 2 years, 6 months ago
Fix four occurrences of the checkpatch.pl error:
ERROR: open brace '{' following enum go on the same line

Signed-off-by: Jie Shi <shijie001@208suo.com>
---
  drivers/gpu/drm/radeon/ni_dpm.h | 12 ++++--------
  1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/radeon/ni_dpm.h 
b/drivers/gpu/drm/radeon/ni_dpm.h
index 74e301936906..4e3e7303e035 100644
--- a/drivers/gpu/drm/radeon/ni_dpm.h
+++ b/drivers/gpu/drm/radeon/ni_dpm.h
@@ -59,8 +59,7 @@ struct ni_mc_reg_table {

  #define NISLANDS_MCREGISTERTABLE_FIRST_DRIVERSTATE_SLOT 2

-enum ni_dc_cac_level
-{
+enum ni_dc_cac_level {
      NISLANDS_DCCAC_LEVEL_0 = 0,
      NISLANDS_DCCAC_LEVEL_1,
      NISLANDS_DCCAC_LEVEL_2,
@@ -72,8 +71,7 @@ enum ni_dc_cac_level
      NISLANDS_DCCAC_MAX_LEVELS
  };

-struct ni_leakage_coeffients
-{
+struct ni_leakage_coeffients {
      u32 at;
      u32 bt;
      u32 av;
@@ -83,8 +81,7 @@ struct ni_leakage_coeffients
      u32 t_ref;
  };

-struct ni_cac_data
-{
+struct ni_cac_data {
      struct ni_leakage_coeffients leakage_coefficients;
      u32 i_leakage;
      s32 leakage_minimum_temperature;
@@ -100,8 +97,7 @@ struct ni_cac_data
      u8 lts_truncate_n;
  };

-struct ni_cac_weights
-{
+struct ni_cac_weights {
      u32 weight_tcp_sig0;
      u32 weight_tcp_sig1;
      u32 weight_ta_sig;
Re: [PATCH] drm/radeon/dpm: ERROR: open brace '{' following enum go on the same line
Posted by Alex Deucher 2 years, 6 months ago
I'm happy to apply these patches, but please check your mailer.  The
formatting is messed up and they don't apply cleanly.  Please use
git-format-patch and git-send-email to generate and send the patches.

Thanks!

Alex

On Fri, Jul 14, 2023 at 3:15 AM <shijie001@208suo.com> wrote:
>
> Fix four occurrences of the checkpatch.pl error:
> ERROR: open brace '{' following enum go on the same line
>
> Signed-off-by: Jie Shi <shijie001@208suo.com>
> ---
>   drivers/gpu/drm/radeon/ni_dpm.h | 12 ++++--------
>   1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/ni_dpm.h
> b/drivers/gpu/drm/radeon/ni_dpm.h
> index 74e301936906..4e3e7303e035 100644
> --- a/drivers/gpu/drm/radeon/ni_dpm.h
> +++ b/drivers/gpu/drm/radeon/ni_dpm.h
> @@ -59,8 +59,7 @@ struct ni_mc_reg_table {
>
>   #define NISLANDS_MCREGISTERTABLE_FIRST_DRIVERSTATE_SLOT 2
>
> -enum ni_dc_cac_level
> -{
> +enum ni_dc_cac_level {
>       NISLANDS_DCCAC_LEVEL_0 = 0,
>       NISLANDS_DCCAC_LEVEL_1,
>       NISLANDS_DCCAC_LEVEL_2,
> @@ -72,8 +71,7 @@ enum ni_dc_cac_level
>       NISLANDS_DCCAC_MAX_LEVELS
>   };
>
> -struct ni_leakage_coeffients
> -{
> +struct ni_leakage_coeffients {
>       u32 at;
>       u32 bt;
>       u32 av;
> @@ -83,8 +81,7 @@ struct ni_leakage_coeffients
>       u32 t_ref;
>   };
>
> -struct ni_cac_data
> -{
> +struct ni_cac_data {
>       struct ni_leakage_coeffients leakage_coefficients;
>       u32 i_leakage;
>       s32 leakage_minimum_temperature;
> @@ -100,8 +97,7 @@ struct ni_cac_data
>       u8 lts_truncate_n;
>   };
>
> -struct ni_cac_weights
> -{
> +struct ni_cac_weights {
>       u32 weight_tcp_sig0;
>       u32 weight_tcp_sig1;
>       u32 weight_ta_sig;