The IMX678 (8MPix) driver has already been accepted into the
kernel.
Whilst preparing a patchset for IMX662 (1080p), I observed such
commonality between the two that it seemed sensible to attempt
a common driver rather than submitting a separate IMX662 series
again.
On checking my box of sensors, I found I had an IMX675 (5MPix) as
well, so that has been incorporated. Subsequently I was able to
add IMX585 (8MPix) and IMX832 (1080p).
The Sony datasheets are rather lacking on the limits for HMAX.
They list HMAX (and VMAX) values for nice round framerates at
a number of the supported link frequencies.
These limits have been adopted for IMX662 and IMX832, but for
IMX675 and IMX585 they have been determined empirically by
observing values of HMAX that start to introduce image issues.
Now cleaned up over the RFC V1.
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
Changes in v6:
Addressing Sakari's comments:
- Updated CAMERA SENSOR DRIVERS in MAINTAINERS
- Used tabs instead of spaces in register defines
- Added myself to MODULE_AUTHOR
- Added Raspberry Pi Ltd to Copyright header
- Reworded dtbinding description to avoid needing a paragraph
- Removed unneeded parentheses and assignment to ret in link freq
patch.
Sashiko:
- pm_runtime accounting error.
- REG_INTERFACE_SEL and the mono ID register have moved for IMX585.
Now parameterised.
Jai:
- Added IMX676 support. Copied from https://lore.kernel.org/linux-media/20261022105623.4179467-2-jai.luthra@ideasonboard.com/
with minor fixups due to the above changes.
- Link to v5: https://lore.kernel.org/r/20261019-media-starvis2-v5-0-eef935347ce9@raspberrypi.com
Changes in v5:
Fix Sashiko issues that were present in V3 but it didn't report.
- v4l2_ctrl_new_int_menu failing for LINK_FREQ could avoid
printing an error.
- Make setting common_regs_written conditional on all cci_write
calls having succeeded.
- Please note that the checkpatch failure on the first patch is
a false positive. starvis2_of_match does have the sentinel, but
it's not shown in this patch as it's being renamed from
imx678_of_match. I'll report the false positive.
- Link to v4: https://lore.kernel.org/r/20261015-media-starvis2-v4-0-75fcdb4163f3@raspberrypi.com
Changes in v4:
- Added Krzysztof's tag
- Made the variant_def structs static (sparse)
- Put the sensor back into standby after identify in case PM is
disabled (sashiko)
- New patch to enable pm_runtime_autosuspend.
- Not fixed a Sashiko report of potential use-after-free with
v4l2_subdev_cleanup vs v4l2-ctrl_handler_free. It is a
pre-existing issue in imx678, and many others are sharing the
same pattern. There is no immediately obvious solution as the
active state is sharing the control handler lock, so the
suggested inversion of operations will use a destroyed mutex.
https://sashiko.dev/#/message/sashiko-outbox-171674%40kernel.org
- Checkpatch error "missing sentinel in ID array" is a false
positive, confused by the comment in the middle of the array.
That comment was pre-existing in imx678.
- Link to v3: https://lore.kernel.org/r/20261014-media-starvis2-v3-0-c958362b5d06@raspberrypi.com
Changes in v3:
- Sorted compatibles list (Krzysztof)
- Corrected exposure limits for imx585 via parameterization (Jai)
Issues identified by Sashiko-bot
- Fixed the Kconfig for VIDEO_IMX678 still depending on GPIOLIB
- Removed the remnant build rule for imx678.o
- Fixed sending the common registers if CONFIG_PM is disabled.
- Fixed potential NULL deref and lockdep in link freq handling.
- Fixed the duplicated active_area definition for imx585
- Link to v2: https://lore.kernel.org/r/20261013-media-starvis2-v2-0-3670722d250a@raspberrypi.com
Changes in v2:
- Switched from an RFC to a patch set.
- Add the dtbinding changes.
- Added IMX832 and IMX585. Tested and fully working on all 5 modules.
- Updated 2 lane handling so that the higher link frequencies achieve
the maximum frame rates.
- Adds a patch that corrects the minimum exposure time.
- Allow userspace selection of all link frequencies specified via DT
(makes testing all the link frequency options far easier).
- Link to v1: https://lore.kernel.org/r/20260805-media-starvis2-v1-0-91e8e4eae44f@raspberrypi.com
---
Dave Stevenson (17):
media: imx678: Rework into generic Starvis 2 sensor driver.
media: sony-starvis2: Reorder link frequencies to remove lookup
media: sony-starvis2: Always program the sensor in window mode
media: sony-starvis2: Parameterise the configuration to allow for other models
media: sony-starvis2: Rework 2 lane support for higher link freqs
media: sony-starvis2: Allow runtime control of link frequency
media: sony-starvis2: Correct the exposure range
media: sony-starvis2: Put module into standby after identify
media: sony-starvis2: Use pm_runtime_autosuspend
media: dt-bindings: sony,imx678: Add other Starvis 2 family members
media: sony-starvis2: Add support for IMX662
media: sony-starvis2: Add support for IMX675
media: sony-starvis2: Add support for IMX832
media: sony-starvis2: Only update bits for window mode
media: sony-starvis2: Parameterise exposure min and step
media: sony-starvis2: Parameterise the mono ID register
media: sony-starvis2: Add support for IMX585
Jai Luthra (1):
media: sony-starvis2: Add support for IMX676
.../devicetree/bindings/media/i2c/sony,imx678.yaml | 44 +-
MAINTAINERS | 15 +-
drivers/media/i2c/Kconfig | 19 +-
drivers/media/i2c/Makefile | 2 +-
drivers/media/i2c/imx678.c | 1447 -----------
drivers/media/i2c/sony-starvis2.c | 2566 ++++++++++++++++++++
6 files changed, 2626 insertions(+), 1467 deletions(-)
---
base-commit: d7e7bca7169873b46e857c025c10f3336c1258d8
change-id: 20260804-media-starvis2-65a5bc405b74
Best regards,
--
Dave Stevenson <dave.stevenson@raspberrypi.com>