[PATCH v5 0/2] Start removing X86_X32_ABI

Sebastian Andrzej Siewior posted 2 patches 1 week ago
arch/x86/Kconfig                               | 2 +-
tools/testing/selftests/nolibc/Makefile.nolibc | 6 ------
tools/testing/selftests/nolibc/run-tests.sh    | 7 +------
3 files changed, 2 insertions(+), 13 deletions(-)
[PATCH v5 0/2] Start removing X86_X32_ABI
Posted by Sebastian Andrzej Siewior 1 week ago
Patch #2 prepares the removal of the X32 ABI and has the broader
reasoning. Patch #1 removes x32 from the selftests because it does not
have a depends on and assumes x32 to be always available on x64 and so
it breaks.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
v4…v5: https://patch.msgid.link/20261008-x32_removal-v4-0-d389a193c506@breakpoint.cc
  - reword commit message for #2 as requested by hpa to state that this
    is the last warning.

v3…v4: https://patch.msgid.link/20260813-x32_removal-v3-0-e8f96cd15478@linutronix.de
  - Depend on BROKEN instead of removing it.

v2…v3: https://patch.msgid.link/20260707212252.bYk3-AlU@linutronix.de
  - added a nolibc-selftests patch to not break it in their setup since
    it does not depend on the symbol.

v1…v2: https://lore.kernel.org/r/20260523093734.A3AR7reJ@linutronix.de
  - reworded commit message

Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Bill Wendling <morbo@google.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Jonathan Corbet <corbet@lwn.net>,
Cc: Justin Stitt <justinstitt@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Neal Gompa <neal@gompa.dev>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>                                                                                           
Cc: Sam James <sam@gentoo.org>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Thomas Gleixner <tglx@kernel.org>
Cc: Thomas Weißschuh <linux@weissschuh.net>
Cc: Tomas Glozar <tglozar@kernel.org>
Cc: Willy Tarreau <w@1wt.eu>
Cc: x86@kernel.org
To: linux-kernel@vger.kernel.org
To: linux-kselftest@vger.kernel.org

---
Sebastian Andrzej Siewior (1):
      x86: Start removing X86_X32_ABI

Thomas Weißschuh (1):
      selftests/nolibc: remove the x32 testcase

 arch/x86/Kconfig                               | 2 +-
 tools/testing/selftests/nolibc/Makefile.nolibc | 6 ------
 tools/testing/selftests/nolibc/run-tests.sh    | 7 +------
 3 files changed, 2 insertions(+), 13 deletions(-)
---
base-commit: ec8bf8280261294a9b9b4520414b42704c7f9f6b
change-id: 20260706-x32_removal-28823498c4a2

Best regards,
--  
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Re: [PATCH v5 0/2] Start removing X86_X32_ABI
Posted by Shuah Khan 1 week ago
On 10/15/26 12:47, Sebastian Andrzej Siewior wrote:
> Patch #2 prepares the removal of the X32 ABI and has the broader
> reasoning. Patch #1 removes x32 from the selftests because it does not
> have a depends on and assumes x32 to be always available on x64 and so
> it breaks.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> v4…v5: https://patch.msgid.link/20261008-x32_removal-v4-0-d389a193c506@breakpoint.cc
>    - reword commit message for #2 as requested by hpa to state that this
>      is the last warning.
> 
> v3…v4: https://patch.msgid.link/20260813-x32_removal-v3-0-e8f96cd15478@linutronix.de
>    - Depend on BROKEN instead of removing it.
> 
> v2…v3: https://patch.msgid.link/20260707212252.bYk3-AlU@linutronix.de
>    - added a nolibc-selftests patch to not break it in their setup since
>      it does not depend on the symbol.
> 
> v1…v2: https://lore.kernel.org/r/20260523093734.A3AR7reJ@linutronix.de
>    - reworded commit message
> 
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>
> Cc: Bill Wendling <morbo@google.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Cc: Jonathan Corbet <corbet@lwn.net>,
> Cc: Justin Stitt <justinstitt@google.com>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Neal Gompa <neal@gompa.dev>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Cc: Sam James <sam@gentoo.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Thomas Gleixner <tglx@kernel.org>
> Cc: Thomas Weißschuh <linux@weissschuh.net>
> Cc: Tomas Glozar <tglozar@kernel.org>
> Cc: Willy Tarreau <w@1wt.eu>
> Cc: x86@kernel.org
> To: linux-kernel@vger.kernel.org
> To: linux-kselftest@vger.kernel.org
> 
> ---
> Sebastian Andrzej Siewior (1):
>        x86: Start removing X86_X32_ABI
> 
> Thomas Weißschuh (1):
>        selftests/nolibc: remove the x32 testcase
> 
>   arch/x86/Kconfig                               | 2 +-
>   tools/testing/selftests/nolibc/Makefile.nolibc | 6 ------
>   tools/testing/selftests/nolibc/run-tests.sh    | 7 +------
>   3 files changed, 2 insertions(+), 13 deletions(-)
> ---

For selftests:

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

Do you plan to cleanup x32 checks from selftests/x86 Makefiles?

thanks,
-- Shuah


Re: [PATCH v5 0/2] Start removing X86_X32_ABI
Posted by Sebastian Andrzej Siewior 3 days, 16 hours ago
On 2026-10-15 13:47:37 [-0600], Shuah Khan wrote:
> For selftests:
> 
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>

Thank you.

> Do you plan to cleanup x32 checks from selftests/x86 Makefiles?

Could you please give me an example? I've been looking through
	tools/testing/selftests/x86

and didn't find anything Makefile + x32 related. Just
syscall_numbering.c which has x32 bits.

> thanks,
> -- Shuah

Sebastian
Re: [PATCH v5 0/2] Start removing X86_X32_ABI
Posted by Shuah Khan 1 day, 8 hours ago
On 10/19/26 04:35, Sebastian Andrzej Siewior wrote:
> On 2026-10-15 13:47:37 [-0600], Shuah Khan wrote:
>> For selftests:
>>
>> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
> 
> Thank you.
> 
>> Do you plan to cleanup x32 checks from selftests/x86 Makefiles?
> 
> Could you please give me an example? I've been looking through
> 	tools/testing/selftests/x86
> 
> and didn't find anything Makefile + x32 related. Just
> syscall_numbering.c which has x32 bits.
> 

Take a look at x86 selftest directory. You will find sigreturn.c
and syscall_numbering.c that have references to x32 syscalls.

Makefile has handling for TARGETS_C_32BIT_ONLY.

thanks,
-- Shuah
Re: [PATCH v5 0/2] Start removing X86_X32_ABI
Posted by Sebastian Andrzej Siewior 11 hours ago
On 2026-10-21 12:31:46 [-0600], Shuah Khan wrote:
> On 10/19/26 04:35, Sebastian Andrzej Siewior wrote:
> > On 2026-10-15 13:47:37 [-0600], Shuah Khan wrote:
> > > For selftests:
> > > 
> > > Acked-by: Shuah Khan <skhan@linuxfoundation.org>
> > 
> > Thank you.
> > 
> > > Do you plan to cleanup x32 checks from selftests/x86 Makefiles?
> > 
> > Could you please give me an example? I've been looking through
> > 	tools/testing/selftests/x86
> > 
> > and didn't find anything Makefile + x32 related. Just
> > syscall_numbering.c which has x32 bits.
> > 
> 
> Take a look at x86 selftest directory. You will find sigreturn.c
> and syscall_numbering.c that have references to x32 syscalls.
> 
> Makefile has handling for TARGETS_C_32BIT_ONLY.

Okay. If x32 marked as broken it does not hurt to the selftests as-is,
right?
I think sigreturn.c can stay as-is except for the comment referring to
x32.
syscall_numbering.c has plenty of x32 bits and I would go and remove
them once start removing the x32 bits. The reason for 1/2 in this series
is that the nolibc selftests expect x32 to be working on x86-64.

But this isn't the case here afaik. Now that I test it run into 
   https://lore.kernel.org/all/20261022142425.3Wx-RrU5@linutronix.de/

so the test is currently broken.

Did I understand you properly?

> thanks,
> -- Shuah

Sebastian
Re: [PATCH v5 0/2] Start removing X86_X32_ABI
Posted by Shuah Khan 10 hours ago
On 10/22/26 09:06, Sebastian Andrzej Siewior wrote:
> On 2026-10-21 12:31:46 [-0600], Shuah Khan wrote:
>> On 10/19/26 04:35, Sebastian Andrzej Siewior wrote:
>>> On 2026-10-15 13:47:37 [-0600], Shuah Khan wrote:
>>>> For selftests:
>>>>
>>>> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
>>>
>>> Thank you.
>>>
>>>> Do you plan to cleanup x32 checks from selftests/x86 Makefiles?
>>>
>>> Could you please give me an example? I've been looking through
>>> 	tools/testing/selftests/x86
>>>
>>> and didn't find anything Makefile + x32 related. Just
>>> syscall_numbering.c which has x32 bits.
>>>
>>
>> Take a look at x86 selftest directory. You will find sigreturn.c
>> and syscall_numbering.c that have references to x32 syscalls.
>>
>> Makefile has handling for TARGETS_C_32BIT_ONLY.
> 
> Okay. If x32 marked as broken it does not hurt to the selftests as-is,
> right?
> I think sigreturn.c can stay as-is except for the comment referring to
> x32.

Right the comment needs cleaning up.

> syscall_numbering.c has plenty of x32 bits and I would go and remove
> them once start removing the x32 bits. The reason for 1/2 in this series
> is that the nolibc selftests expect x32 to be working on x86-64.

Perfect.

> 
> But this isn't the case here afaik. Now that I test it run into
>     https://lore.kernel.org/all/20261022142425.3Wx-RrU5@linutronix.de/
> 
> so the test is currently broken.

Probably. I haven't investigated.

> 
> Did I understand you properly?

Yes. My objective is to get these items on your list to take a
look and address whichever you see fit and we accomplished it. :)

thanks,
-- Shuah
Re: [PATCH v5 0/2] Start removing X86_X32_ABI
Posted by Sebastian Andrzej Siewior 10 hours ago
On 2026-10-22 09:55:43 [-0600], Shuah Khan wrote:
> > But this isn't the case here afaik. Now that I test it run into
> >     https://lore.kernel.org/all/20261022142425.3Wx-RrU5@linutronix.de/
> > 
> > so the test is currently broken.
> 
> Probably. I haven't investigated.

I poked the one that made the change and lets see what happens…

> > 
> > Did I understand you properly?
> 
> Yes. My objective is to get these items on your list to take a
> look and address whichever you see fit and we accomplished it. :)

Okay, perfect.

> thanks,
> -- Shuah

Sebastian