[PATCH v5 0/2] staging: rtl8723bs: clean up phy status structs and casts

Timo Joannin posted 2 patches 1 week, 3 days ago
drivers/staging/rtl8723bs/hal/odm_HWConfig.c  | 215 +++++++++++-------
.../staging/rtl8723bs/include/rtl8192c_recv.h |  18 --
.../staging/rtl8723bs/include/rtl8723b_recv.h |   1 -
3 files changed, 134 insertions(+), 100 deletions(-)
[PATCH v5 0/2] staging: rtl8723bs: clean up phy status structs and casts
Posted by Timo Joannin 1 week, 3 days ago
Hey Now,

This patch series splits the v3 patch into a 2-part series as requested,
separating the struct renaming from the cast mess unwinding.

Changes in v5:
- Rebased against the latest staging/staging-testing branch.
- Resolved minor merge conflicts in odm_HWConfig.c.

Changes in v4:
- Split monolithic patch into 2-part series.
- Removed dead struct phy_stat and unused prototype
rtl8723b_query_rx_phy_status().

Changes in v3:
- Included patch version changelog (missed in v2, sorry).

Changes in v2:
- Propagated the real struct type through
the call chain to remove u8 * casting.

Regarding your question about the existence of struct phy_stat,
I discovered it was dead code; no function actually used it. Furthermore,
the rtl8723b_query_rx_phy_status() function prototype referencing
it was also unused, and was removed.

Patch 1 renames struct phy_status_rpt_8192cd_t
to rtl8723bs_phy_status_rpt.

Patch 2 unwinds the cast mess and propagates
the real struct type all the way through
the call chain, and removes the unused phy_stat struct
and ghost function prototype.

Timo Joannin (2):
  staging: rtl8723bs: rename struct phy_status_rpt_8192cd_t to
    rtl8723bs_phy_status_rpt.
  staging: rtl8723bs: unwind cast mess and remove phy_stat struct

 drivers/staging/rtl8723bs/hal/odm_HWConfig.c  | 215 +++++++++++-------
 .../staging/rtl8723bs/include/rtl8192c_recv.h |  18 --
 .../staging/rtl8723bs/include/rtl8723b_recv.h |   1 -
 3 files changed, 134 insertions(+), 100 deletions(-)

-- 
2.56.0