counter: ti-ecap-capture: use regmap_assign_bits() for conditional set/clear

[PATCH] counter: ti-ecap-capture: use regmap_assign_bits() for conditional set/clear

Posted by Peng Fan (OSS) 3 hours ago

From: Peng Fan <peng.fan@nxp.com>

Replace if/else block using regmap_set_bits()/regmap_clear_bits() with
the simpler regmap_assign_bits() call.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/counter/ti-ecap-capture.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/counter/ti-ecap-capture.c b/drivers/counter/ti-ecap-capture.c
index d77a256f0ed31..1b79031544646 100644
--- a/drivers/counter/ti-ecap-capture.c
+++ b/drivers/counter/ti-ecap-capture.c
@@ -254,10 +254,8 @@ static int ecap_cnt_pol_write(struct counter_device *counter,
 	struct ecap_cnt_dev *ecap_dev = counter_priv(counter);
 
 	pm_runtime_get_sync(counter->parent);
-	if (pol == COUNTER_SIGNAL_POLARITY_NEGATIVE)
-		regmap_set_bits(ecap_dev->regmap, ECAP_ECCTL_REG, ECAP_CAPPOL_BIT(idx));
-	else
-		regmap_clear_bits(ecap_dev->regmap, ECAP_ECCTL_REG, ECAP_CAPPOL_BIT(idx));
+	regmap_assign_bits(ecap_dev->regmap, ECAP_ECCTL_REG, ECAP_CAPPOL_BIT(idx),
+			   pol == COUNTER_SIGNAL_POLARITY_NEGATIVE);
 	pm_runtime_put_sync(counter->parent);
 
 	return 0;
-- 
2.50.1

Re: [PATCH] counter: ti-ecap-capture: use regmap_assign_bits() for conditional set/clear

Posted by Julien Panis an hour ago

On 9/24/26 10:34, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Replace if/else block using regmap_set_bits()/regmap_clear_bits() with
> the simpler regmap_assign_bits() call.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>   drivers/counter/ti-ecap-capture.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/counter/ti-ecap-capture.c b/drivers/counter/ti-ecap-capture.c
> index d77a256f0ed31..1b79031544646 100644
> --- a/drivers/counter/ti-ecap-capture.c
> +++ b/drivers/counter/ti-ecap-capture.c
> @@ -254,10 +254,8 @@ static int ecap_cnt_pol_write(struct counter_device *counter,
>   	struct ecap_cnt_dev *ecap_dev = counter_priv(counter);
>   
>   	pm_runtime_get_sync(counter->parent);
> -	if (pol == COUNTER_SIGNAL_POLARITY_NEGATIVE)
> -		regmap_set_bits(ecap_dev->regmap, ECAP_ECCTL_REG, ECAP_CAPPOL_BIT(idx));
> -	else
> -		regmap_clear_bits(ecap_dev->regmap, ECAP_ECCTL_REG, ECAP_CAPPOL_BIT(idx));
> +	regmap_assign_bits(ecap_dev->regmap, ECAP_ECCTL_REG, ECAP_CAPPOL_BIT(idx),
> +			   pol == COUNTER_SIGNAL_POLARITY_NEGATIVE);
>   	pm_runtime_put_sync(counter->parent);
>   
>   	return 0;

Acked-by: Julien Panis <jpanis@baylibre.com>