[v2] lockd: allow setting ports without setting gracetime

[PATCH v2 0/2] lockd: allow setting ports without setting gracetime

Jeff Layton posted 2 patches 20 hours ago

Diff against v1
Download series mbox

fs/lockd/svc.c                                    |  50 ++--
tools/testing/selftests/nfsd/.gitignore           |   1 +
tools/testing/selftests/nfsd/Makefile             |   1 +
tools/testing/selftests/nfsd/nfsd_lockd_netlink.c | 268 ++++++++++++++++++++++
tools/testing/selftests/nfsd/nfsd_netlink.h       |  90 ++++++--
5 files changed, 367 insertions(+), 43 deletions(-)

Expand all Fold all

[PATCH v2 0/2] lockd: allow setting ports without setting gracetime

Posted by Jeff Layton 20 hours ago

This version fixes some selftest coverage gaps that Sashiko pointed out.
The actual bugfix is unchanged.

This patchset fixes a rather silly bug that Scott pointed out to me in a
meeting recently. You currently can't set the ports in lockd via the
netlink interface unless you also set the gracetime. This patch makes
them all properly optional.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Changes in v2:
- selftests: split put_ports() into put_tcp_port()/put_udp_port() helpers
- selftests: attributes_are_set_independently now also covers a UDP-only SERVER_SET
- selftests: empty_set_is_a_noop and settings_are_per_netns now set and check gracetime too
- Link to v1: https://lore.kernel.org/r/20260923-nfsd-testing-v1-0-a793f54a4dd1@kernel.org

---
Jeff Layton (2):
      lockd: allow SERVER_SET without a gracetime attribute
      selftests/nfsd: add lockd netlink configuration tests

 fs/lockd/svc.c                                    |  50 ++--
 tools/testing/selftests/nfsd/.gitignore           |   1 +
 tools/testing/selftests/nfsd/Makefile             |   1 +
 tools/testing/selftests/nfsd/nfsd_lockd_netlink.c | 268 ++++++++++++++++++++++
 tools/testing/selftests/nfsd/nfsd_netlink.h       |  90 ++++++--
 5 files changed, 367 insertions(+), 43 deletions(-)
---
base-commit: cab95e6be3ba82bcf4c8be27c2eb20e55238aa41
change-id: 20260922-nfsd-testing-00c12335047d

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>

Re: [PATCH v2 0/2] lockd: allow setting ports without setting gracetime

Posted by Chuck Lever 17 hours ago

On Wed, 23 Sep 2026 11:30:49 -0400, Jeff Layton wrote:
> This version fixes some selftest coverage gaps that Sashiko pointed out.
> The actual bugfix is unchanged.
> 
> This patchset fixes a rather silly bug that Scott pointed out to me in a
> meeting recently. You currently can't set the ports in lockd via the
> netlink interface unless you also set the gracetime. This patch makes
> them all properly optional.
> 
> [...]

Applied to nfsd-testing, thanks!

[1/2] lockd: allow SERVER_SET without a gracetime attribute
      commit: 06ed8fb285705890e83b7e199141a9f488286bb9
[2/2] selftests/nfsd: add lockd netlink configuration tests
      commit: 12dbf3be3c58e190c4173471d79ba0b19178447c

--
Chuck Lever