[PATCH] net: phy: aquantia: AQR113c fix up PMA capabilities

Hongmei Xu posted 1 patch 1 day, 11 hours ago
drivers/net/phy/aquantia/aquantia_main.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
[PATCH] net: phy: aquantia: AQR113c fix up PMA capabilities
Posted by Hongmei Xu 1 day, 11 hours ago
AQR113c does not report few of the supported PMA
capabilities which includes speeds like 10G/5G/2.5G,
add get features support within aquantia driver to fix
the same.

Signed-off-by: Hongmei Xu <hongmei.xu@oss.qualcomm.com>
---
 drivers/net/phy/aquantia/aquantia_main.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c
index e95d391a6dc2..604f5492515d 100644
--- a/drivers/net/phy/aquantia/aquantia_main.c
+++ b/drivers/net/phy/aquantia/aquantia_main.c
@@ -1094,6 +1094,18 @@ static int aqr111_get_features(struct phy_device *phydev)
 	return 0;
 }
 
+static int aqr113c_get_features(struct phy_device *phydev)
+{
+	/* Generic C45 PMA abilities do not fully describe the PHY's copper
+	 * autonegotiation modes, so add the 10G mode explicitly.
+	 */
+	aqr111_get_features(phydev);
+	linkmode_set_bit(ETHTOOL_LINK_MODE_10000baseT_Full_BIT,
+			 phydev->supported);
+
+	return 0;
+}
+
 static int aqr_gen4_config_init(struct phy_device *phydev)
 {
 	struct aqr107_priv *priv = phydev->priv;
@@ -1444,6 +1456,7 @@ static struct phy_driver aqr_driver[] = {
 	.get_sset_count = aqr107_get_sset_count,
 	.get_strings    = aqr107_get_strings,
 	.get_stats      = aqr107_get_stats,
+	.get_features   = aqr113c_get_features,
 	.link_change_notify = aqr107_link_change_notify,
 	.led_brightness_set = aqr_phy_led_brightness_set,
 	.led_hw_is_supported = aqr_phy_led_hw_is_supported,

---
base-commit: 063510768490d85454a99b27be303aad5efdf624
change-id: 20260917-net-phy-aqr113c-fix-pma-capability-d7d08cbc9879

Best regards,
--  
Hongmei Xu <hongmei.xu@oss.qualcomm.com>
Re: [PATCH] net: phy: aquantia: AQR113c fix up PMA capabilities
Posted by Andrew Lunn 22 hours ago
On Wed, Sep 23, 2026 at 10:02:29AM +0800, Hongmei Xu wrote:
> AQR113c does not report few of the supported PMA
> capabilities which includes speeds like 10G/5G/2.5G,
> add get features support within aquantia driver to fix
> the same.
> 
> Signed-off-by: Hongmei Xu <hongmei.xu@oss.qualcomm.com>

Please set the Subject line correctly.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Does the AQR113 also get its features wrong?

	Andrew
Re: [PATCH] net: phy: aquantia: AQR113c fix up PMA capabilities
Posted by Hongmei Xu 10 hours ago
We only have AQR113C hardware available for testing. The AQR113 may
have the same issue, but since we cannot verify it, this patch
intentionally limits the change to AQR113C only.

If someone with AQR113 hardware can confirm the same behavior, he or
she can send a follow-up patch to extend get_features() to cover that 
PHY as well.

On 9/23/2026 11:26 PM, Andrew Lunn wrote:
> Does the AQR113 also get its features wrong?
Re: [PATCH] net: phy: aquantia: AQR113c fix up PMA capabilities
Posted by Andrew Lunn 58 minutes ago
On Thu, Sep 24, 2026 at 11:41:53AM +0800, Hongmei Xu wrote:
> We only have AQR113C hardware available for testing. The AQR113 may
> have the same issue, but since we cannot verify it, this patch
> intentionally limits the change to AQR113C only.

Do you have access to the datasheet? Any erratas?

If not, please extend the commit message with a comment that the same
issue might apply to the AQR113.

      Andrew