drivers/iio/accel/bmc150-accel-core.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
From: Carlos Casadiego <cdcp206@gmail.com>
The software reset is required to bring the device into a known
state before reading the chip ID.
Check the return value of regmap_write() and abort initialization if
the reset command cannot be written.
Fixes: 1c500840934a ("iio: accel: bmc150: reset chip at init time")
Signed-off-by: Carlos Casadiego <cdcp206@gmail.com>
---
drivers/iio/accel/bmc150-accel-core.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
index 46bb36d9366e..43a39e1ccce5 100644
--- a/drivers/iio/accel/bmc150-accel-core.c
+++ b/drivers/iio/accel/bmc150-accel-core.c
@@ -1561,8 +1561,12 @@ static int bmc150_accel_chip_init(struct bmc150_accel_data *data)
* Reset chip to get it in a known good state. A delay of 1.8ms after
* reset is required according to the data sheets of supported chips.
*/
- regmap_write(data->regmap, BMC150_ACCEL_REG_RESET,
- BMC150_ACCEL_RESET_VAL);
+ ret = regmap_write(data->regmap, BMC150_ACCEL_REG_RESET,
+ BMC150_ACCEL_RESET_VAL);
+ if (ret < 0) {
+ dev_err(dev, "Error writing reset register\n");
+ return ret;
+ }
usleep_range(1800, 2500);
ret = regmap_read(data->regmap, BMC150_ACCEL_REG_CHIP_ID, &val);
---
base-commit: d8c0f48f0b1583308a98401c0c7b1a65d1d43a6c
change-id: 20260923-iio-bmc150-check-reset-error-389b096b0ad4
Best regards,
--
Carlos Casadiego <cdcp206@gmail.com>
On Wed, 2026-09-23 at 11:41 -0500, Carlos Casadiego via B4 Relay wrote:
> From: Carlos Casadiego <cdcp206@gmail.com>
>
> The software reset is required to bring the device into a known
> state before reading the chip ID.
>
> Check the return value of regmap_write() and abort initialization if
> the reset command cannot be written.
>
> Fixes: 1c500840934a ("iio: accel: bmc150: reset chip at init time")
>
> Signed-off-by: Carlos Casadiego <cdcp206@gmail.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/iio/accel/bmc150-accel-core.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/bmc150-accel-core.c
> b/drivers/iio/accel/bmc150-accel-core.c
> index 46bb36d9366e..43a39e1ccce5 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -1561,8 +1561,12 @@ static int bmc150_accel_chip_init(struct
> bmc150_accel_data *data)
> * Reset chip to get it in a known good state. A delay of
> 1.8ms after
> * reset is required according to the data sheets of
> supported chips.
> */
> - regmap_write(data->regmap, BMC150_ACCEL_REG_RESET,
> - BMC150_ACCEL_RESET_VAL);
> + ret = regmap_write(data->regmap, BMC150_ACCEL_REG_RESET,
> + BMC150_ACCEL_RESET_VAL);
> + if (ret < 0) {
> + dev_err(dev, "Error writing reset register\n");
> + return ret;
> + }
> usleep_range(1800, 2500);
>
> ret = regmap_read(data->regmap, BMC150_ACCEL_REG_CHIP_ID,
> &val);
>
> ---
> base-commit: d8c0f48f0b1583308a98401c0c7b1a65d1d43a6c
> change-id: 20260923-iio-bmc150-check-reset-error-389b096b0ad4
>
> Best regards,
> --
> Carlos Casadiego <cdcp206@gmail.com>
>
© 2016 - 2026 Red Hat, Inc.