staging: sm750fb: fix const pointer declaration in sm750.c

[PATCH] staging: sm750fb: fix const pointer declaration in sm750.c

Posted by Vladan Kalaba 1 day, 18 hours ago

Fix static const char * declaration for g_fbmode[] to static const
char * const as reported by checkpatch to cohere to Linux kernel
coding standards.

Signed-off-by: Vladan Kalaba <vladan.kalaba@gmail.com>
---
 drivers/staging/sm750fb/sm750.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 1ea3dd8b8f28..79d0221cdeae 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -12,7 +12,7 @@
 static int g_hwcursor = 1;
 static int g_noaccel __ro_after_init;
 static int g_nomtrr __ro_after_init;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
 static const char * const g_def_fbmode = "1024x768-32@60";
 static char *g_settings;
 static int g_dualview __ro_after_init;
-- 
2.53.0

Re: [PATCH] staging: sm750fb: fix const pointer declaration in sm750.c

Posted by Ahmet Sezgin Duran 1 day, 6 hours ago

On 9/22/26 10:36 PM, Vladan Kalaba wrote:
> Fix static const char * declaration for g_fbmode[] to static const
> char * const as reported by checkpatch to cohere to Linux kernel
> coding standards.
> 
> Signed-off-by: Vladan Kalaba <vladan.kalaba@gmail.com>
> ---
>   drivers/staging/sm750fb/sm750.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 1ea3dd8b8f28..79d0221cdeae 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -12,7 +12,7 @@
>   static int g_hwcursor = 1;
>   static int g_noaccel __ro_after_init;
>   static int g_nomtrr __ro_after_init;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};
>   static const char * const g_def_fbmode = "1024x768-32@60";
>   static char *g_settings;
>   static int g_dualview __ro_after_init;

Did you compile this patch? While SM750 module is enabled?

Regards,
Ahmet Sezgin Duran

Re: [PATCH] staging: sm750fb: fix const pointer declaration in sm750.c

Posted by Vladan Kalaba 19 hours ago

On Wed, Sep 23, 2026 at 10:28 AM Ahmet Sezgin Duran
<ahmet@sezginduran.net> wrote:
>
> On 9/22/26 10:36 PM, Vladan Kalaba wrote:
> > Fix static const char * declaration for g_fbmode[] to static const
> > char * const as reported by checkpatch to cohere to Linux kernel
> > coding standards.
> >
> > Signed-off-by: Vladan Kalaba <vladan.kalaba@gmail.com>
> > ---
> >   drivers/staging/sm750fb/sm750.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> > index 1ea3dd8b8f28..79d0221cdeae 100644
> > --- a/drivers/staging/sm750fb/sm750.c
> > +++ b/drivers/staging/sm750fb/sm750.c
> > @@ -12,7 +12,7 @@
> >   static int g_hwcursor = 1;
> >   static int g_noaccel __ro_after_init;
> >   static int g_nomtrr __ro_after_init;
> > -static const char *g_fbmode[] = {NULL, NULL};
> > +static const char * const g_fbmode[] = {NULL, NULL};
> >   static const char * const g_def_fbmode = "1024x768-32@60";
> >   static char *g_settings;
> >   static int g_dualview __ro_after_init;
>
> Did you compile this patch? While SM750 module is enabled?
>
> Regards,
> Ahmet Sezgin Duran
Hi Ahmet,
My make defconfig didn't compile in SM750, my bad sorry.
Will double check that in the future.

Sincerely,
Vladan