[v1] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes

[PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes

Posted by Alexandru Chimac 2 days, 2 hours ago

All Exynos9610 pin controllers (except PINCTRL_TOP) have clocks assigned
to them, so force the nodes to have clocks assigned to them.

Signed-off-by: Alexandru Chimac <alex@chimac.ro>
---
Most Samsung Exynos9610 pin controllers (except TOP) have clocks
designated for them, so allow the device tree node to include clock
information for the driver.
---
 Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
index 1feb6a6fc690..e4fdedb29631 100644
--- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
@@ -140,6 +140,7 @@ allOf:
             enum:
               - google,gs101-pinctrl
               - samsung,exynos8890-pinctrl
+              - samsung,exynos9610-pinctrl
     then:
       required:
         - clocks

---
base-commit: c2cd463d6ee7d55a3ec0719d93c49ff99022d58f
change-id: 20260922-exynos9610-pinctrl-patch-e0cc7118dc97

Best regards,
--  
Alexandru Chimac <alex@chimac.ro>

Re: [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes

Posted by Krzysztof Kozlowski 23 hours ago

On 22/09/2026 14:15, Alexandru Chimac wrote:
> All Exynos9610 pin controllers (except PINCTRL_TOP) have clocks assigned
> to them, so force the nodes to have clocks assigned to them.
> 
> Signed-off-by: Alexandru Chimac <alex@chimac.ro>
> ---
> Most Samsung Exynos9610 pin controllers (except TOP) have clocks
> designated for them, so allow the device tree node to include clock

I don't understand above. It's contradictory to commit msg which says
ALL. Here you say most.


Why two commit msgs?

> information for the driver.

that's ABI break without reason.


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes

Posted by Alexandru Chimac 22 hours ago

Hello!
> On 09/23/2026 5:58 PM EEST Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
>  
> On 22/09/2026 14:15, Alexandru Chimac wrote:
> > All Exynos9610 pin controllers (except PINCTRL_TOP) have clocks assigned
> > to them, so force the nodes to have clocks assigned to them.
> > 
> > Signed-off-by: Alexandru Chimac <alex@chimac.ro>
> > ---
> > Most Samsung Exynos9610 pin controllers (except TOP) have clocks
> > designated for them, so allow the device tree node to include clock
> 
> I don't understand above. It's contradictory to commit msg which says
> ALL. Here you say most.
> 

On Exynos9610, only TOP pinctrl doesn't have a clock (as far as I'm
aware; haven't found a clock for it), while the rest of the pin controller
blocks do.

> 
> Why two commit msgs?

The first message is the commit message, and the second one is the b4
cover message. I wasn't actually sure how b4 handles that.

> 
> > information for the driver.
> 
> that's ABI break without reason.
> 

AFAIK there are no (publicly available) users of this device, so this
change shouldn't break any currently available device trees.

The best (most correct imo) implementation would be having the clock
properties be optional, pin controllers for Exynos9610 don't need
to be controlled by Linux for suspend/restore (change is more for
information(?) correctness anyway), since the CMUs should have HWACG
enabled anyway.

Regards,
Alexandru Chimac <alex@chimac.ro

Re: [PATCH] dt-bindings: pinctrl: samsung: Require clocks for Exynos9610 pinctrl nodes

Posted by Alexandru Chimac 2 days ago

Sorry for the spam, I had some issues with the mail host but they're all
fixed now.

> On 09/22/2026 3:15 PM EEST Alexandru Chimac <alex@chimac.ro> wrote:
> 
>  
> All Exynos9610 pin controllers (except PINCTRL_TOP) have clocks assigned
> to them, so force the nodes to have clocks assigned to them.
> 
> Signed-off-by: Alexandru Chimac <alex@chimac.ro>
> ---
> Most Samsung Exynos9610 pin controllers (except TOP) have clocks
> designated for them, so allow the device tree node to include clock
> information for the driver.
> ---
>  Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> index 1feb6a6fc690..e4fdedb29631 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml
> @@ -140,6 +140,7 @@ allOf:
>              enum:
>                - google,gs101-pinctrl
>                - samsung,exynos8890-pinctrl
> +              - samsung,exynos9610-pinctrl
>      then:
>        required:
>          - clocks
> 
> ---
> base-commit: c2cd463d6ee7d55a3ec0719d93c49ff99022d58f
> change-id: 20260922-exynos9610-pinctrl-patch-e0cc7118dc97
> 
> Best regards,
> --  
> Alexandru Chimac <alex@chimac.ro>