[v1] dt-bindings: iommu: Describe MT8195 infra IRQs

[PATCH] dt-bindings: iommu: Describe MT8195 infra IRQs

Posted by Rob Herring (Arm) 2 days, 17 hours ago

The MT8195 infra IOMMU has one fault interrupt per IOMMU bank. Require
the five bank interrupts, named bank0 through bank4, for this
compatible. Keep other MediaTek IOMMUs limited to one unnamed interrupt.

Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../bindings/iommu/mediatek,iommu.yaml        | 30 ++++++++++++++++++-
 arch/arm64/boot/dts/mediatek/mt8195.dtsi      |  2 ++
 2 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
index 79c573c47b08..4dc5621c17e1 100644
--- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
@@ -100,7 +100,11 @@ properties:
     maxItems: 1
 
   interrupts:
-    maxItems: 1
+    minItems: 1
+    maxItems: 5
+
+  interrupt-names:
+    description: Names of IOMMU banks providing fault interrupts.
 
   clocks:
     items:
@@ -155,6 +159,30 @@ required:
   - '#iommu-cells'
 
 allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: mediatek,mt8195-iommu-infra
+    then:
+      properties:
+        interrupts:
+          minItems: 5
+        interrupt-names:
+          items:
+            - const: bank0
+            - const: bank1
+            - const: bank2
+            - const: bank3
+            - const: bank4
+      required:
+        - interrupt-names
+    else:
+      properties:
+        interrupts:
+          maxItems: 1
+        interrupt-names: false
+
   - if:
       properties:
         compatible:
diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index 9aaf8b6edcb5..3e46ffaa44c6 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -937,6 +937,8 @@ iommu_infra: infra-iommu@10315000 {
 				     <GIC_SPI 797 IRQ_TYPE_LEVEL_HIGH 0>,
 				     <GIC_SPI 798 IRQ_TYPE_LEVEL_HIGH 0>,
 				     <GIC_SPI 799 IRQ_TYPE_LEVEL_HIGH 0>;
+			interrupt-names = "bank0", "bank1", "bank2", "bank3",
+					  "bank4";
 			#iommu-cells = <1>;
 		};
 
-- 
2.53.0

Re: [PATCH] dt-bindings: iommu: Describe MT8195 infra IRQs

Posted by AngeloGioacchino Del Regno 2 days, 5 hours ago

On 9/22/26 01:27, Rob Herring (Arm) wrote:
> The MT8195 infra IOMMU has one fault interrupt per IOMMU bank. Require
> the five bank interrupts, named bank0 through bank4, for this
> compatible. Keep other MediaTek IOMMUs limited to one unnamed interrupt.
> 

Why are you introducing interrupt-names, and why would that be a required property?

I disagree - interrupt names are not necessary here.

Cheers,
Angelo

> Assisted-by: LLM
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>   .../bindings/iommu/mediatek,iommu.yaml        | 30 ++++++++++++++++++-
>   arch/arm64/boot/dts/mediatek/mt8195.dtsi      |  2 ++
>   2 files changed, 31 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> index 79c573c47b08..4dc5621c17e1 100644
> --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
> @@ -100,7 +100,11 @@ properties:
>       maxItems: 1
>   
>     interrupts:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 5
> +
> +  interrupt-names:
> +    description: Names of IOMMU banks providing fault interrupts.
>   
>     clocks:
>       items:
> @@ -155,6 +159,30 @@ required:
>     - '#iommu-cells'
>   
>   allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: mediatek,mt8195-iommu-infra
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 5
> +        interrupt-names:
> +          items:
> +            - const: bank0
> +            - const: bank1
> +            - const: bank2
> +            - const: bank3
> +            - const: bank4
> +      required:
> +        - interrupt-names
> +    else:
> +      properties:
> +        interrupts:
> +          maxItems: 1
> +        interrupt-names: false
> +
>     - if:
>         properties:
>           compatible:
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 9aaf8b6edcb5..3e46ffaa44c6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -937,6 +937,8 @@ iommu_infra: infra-iommu@10315000 {
>   				     <GIC_SPI 797 IRQ_TYPE_LEVEL_HIGH 0>,
>   				     <GIC_SPI 798 IRQ_TYPE_LEVEL_HIGH 0>,
>   				     <GIC_SPI 799 IRQ_TYPE_LEVEL_HIGH 0>;
> +			interrupt-names = "bank0", "bank1", "bank2", "bank3",
> +					  "bank4";
>   			#iommu-cells = <1>;
>   		};
>

Re: [PATCH] dt-bindings: iommu: Describe MT8195 infra IRQs

Posted by Rob Herring 1 day, 1 hour ago

On Tue, Sep 22, 2026 at 01:45:05PM +0200, AngeloGioacchino Del Regno wrote:
> On 9/22/26 01:27, Rob Herring (Arm) wrote:
> > The MT8195 infra IOMMU has one fault interrupt per IOMMU bank. Require
> > the five bank interrupts, named bank0 through bank4, for this
> > compatible. Keep other MediaTek IOMMUs limited to one unnamed interrupt.
> > 
> 
> Why are you introducing interrupt-names, and why would that be a required property?
> 
> I disagree - interrupt names are not necessary here.

I agree. Not enough review of this one on my part.

Rob