[PATCH] drm/v3d: Restrict v3d_perfmon_stop_locked() to v3d_perfmon.c

Erick Karanja posted 1 patch 2 days, 22 hours ago
drivers/gpu/drm/v3d/v3d_drv.h     | 2 --
drivers/gpu/drm/v3d/v3d_perfmon.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
[PATCH] drm/v3d: Restrict v3d_perfmon_stop_locked() to v3d_perfmon.c
Posted by Erick Karanja 2 days, 22 hours ago
v3d_perfmon_stop_locked() is only used within v3d_perfmon.c.
Make the function file-local and remove its declaration from v3d_drv.h.

Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
 drivers/gpu/drm/v3d/v3d_drv.h     | 2 --
 drivers/gpu/drm/v3d/v3d_perfmon.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/v3d/v3d_drv.h b/drivers/gpu/drm/v3d/v3d_drv.h
index 29fa14be130b..611618030519 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.h
+++ b/drivers/gpu/drm/v3d/v3d_drv.h
@@ -703,8 +703,6 @@ void v3d_perfmon_put(struct v3d_perfmon *perfmon);
 void v3d_perfmon_start(struct v3d_dev *v3d, struct v3d_perfmon *perfmon);
 void v3d_perfmon_stop(struct v3d_dev *v3d, struct v3d_perfmon *perfmon,
 		      bool capture);
-void v3d_perfmon_stop_locked(struct v3d_dev *v3d, struct v3d_perfmon *perfmon,
-			     bool capture);
 void v3d_perfmon_suspend(struct v3d_dev *v3d);
 void v3d_perfmon_resume(struct v3d_dev *v3d);
 struct v3d_perfmon *v3d_perfmon_find(struct v3d_file_priv *v3d_priv, int id);
diff --git a/drivers/gpu/drm/v3d/v3d_perfmon.c b/drivers/gpu/drm/v3d/v3d_perfmon.c
index 07dab7fb3060..34f17e7b8f6b 100644
--- a/drivers/gpu/drm/v3d/v3d_perfmon.c
+++ b/drivers/gpu/drm/v3d/v3d_perfmon.c
@@ -305,7 +305,7 @@ static void v3d_perfmon_capture_locked(struct v3d_dev *v3d,
 	v3d_pm_runtime_put(v3d);
 }
 
-void v3d_perfmon_stop_locked(struct v3d_dev *v3d, struct v3d_perfmon *perfmon,
+static void v3d_perfmon_stop_locked(struct v3d_dev *v3d, struct v3d_perfmon *perfmon,
 			     bool capture)
 {
 	lockdep_assert_held(&v3d->perfmon_state.lock);
-- 
2.53.0
Re: [PATCH] drm/v3d: Restrict v3d_perfmon_stop_locked() to v3d_perfmon.c
Posted by Maíra Canal 2 days, 21 hours ago
On Mon, 21 Sep 2026 22:00:14 +0300, Erick Karanja wrote:
> v3d_perfmon_stop_locked() is only used within v3d_perfmon.c.
> Make the function file-local and remove its declaration from v3d_drv.h.
> 
> 

Applied with checkpatch fixes, thanks! Please, always verify for checkpatch
issues before submitting patches.

[1/1] drm/v3d: Restrict v3d_perfmon_stop_locked() to v3d_perfmon.c
      commit: 8ef59ee794076e2b58cff357b12de2ba5d441271

Best regards,
- Maíra