[PATCH 0/3] Fix a few Sashiko flagged issues on AMD_HFI

Mario Limonciello posted 3 patches 3 days, 1 hour ago
drivers/platform/x86/amd/hfi/hfi.c | 34 ++++++++++++++++++------------
1 file changed, 21 insertions(+), 13 deletions(-)
[PATCH 0/3] Fix a few Sashiko flagged issues on AMD_HFI
Posted by Mario Limonciello 3 days, 1 hour ago
Sashiko flagged a few instances that could trigger out of bounds or
use-after-free.  This series fixes them.

Mario Limonciello (3):
  platform/x86/amd: hfi: Fix a use-after-free when unloading the driver
  platform/x86/amd: hfi: Fix out-of-bounds reads when parsing ranking
    data
  platform/x86/amd: hfi: Rely on ACPI enumeration instead of a dummy
    device

 drivers/platform/x86/amd/hfi/hfi.c | 34 ++++++++++++++++++------------
 1 file changed, 21 insertions(+), 13 deletions(-)

-- 
2.55.0
Re: [PATCH 0/3] Fix a few Sashiko flagged issues on AMD_HFI
Posted by Ilpo Järvinen 3 days, 1 hour ago
On Mon, 21 Sep 2026, Mario Limonciello wrote:

> Sashiko flagged a few instances that could trigger out of bounds or
> use-after-free.  This series fixes them.

Hi,

I suppose it would be fair to credit sashiko with tags.

> Mario Limonciello (3):
>   platform/x86/amd: hfi: Fix a use-after-free when unloading the driver
>   platform/x86/amd: hfi: Fix out-of-bounds reads when parsing ranking
>     data
>   platform/x86/amd: hfi: Rely on ACPI enumeration instead of a dummy
>     device
> 
>  drivers/platform/x86/amd/hfi/hfi.c | 34 ++++++++++++++++++------------
>  1 file changed, 21 insertions(+), 13 deletions(-)
> 
> 

-- 
 i.
Re: [PATCH 0/3] Fix a few Sashiko flagged issues on AMD_HFI
Posted by Mario Limonciello 3 days, 1 hour ago

On 9/21/26 12:10, Ilpo Järvinen wrote:
> On Mon, 21 Sep 2026, Mario Limonciello wrote:
> 
>> Sashiko flagged a few instances that could trigger out of bounds or
>> use-after-free.  This series fixes them.
> 
> Hi,
> 
> I suppose it would be fair to credit sashiko with tags.
> 
>> Mario Limonciello (3):
>>    platform/x86/amd: hfi: Fix a use-after-free when unloading the driver
>>    platform/x86/amd: hfi: Fix out-of-bounds reads when parsing ranking
>>      data
>>    platform/x86/amd: hfi: Rely on ACPI enumeration instead of a dummy
>>      device
>>
>>   drivers/platform/x86/amd/hfi/hfi.c | 34 ++++++++++++++++++------------
>>   1 file changed, 21 insertions(+), 13 deletions(-)
>>
>>
> 

What tag would I use?  The Sashiko URLs appear to be private (or at 
least I need to be logged in).

Something like:

Reported-by: Sashiko

or

Reported-by: Sashiko
Closes: <private-sashiko-url>
Re: [PATCH 0/3] Fix a few Sashiko flagged issues on AMD_HFI
Posted by Ilpo Järvinen 3 days, 1 hour ago
On Mon, 21 Sep 2026, Mario Limonciello wrote:
> On 9/21/26 12:10, Ilpo Järvinen wrote:
> > On Mon, 21 Sep 2026, Mario Limonciello wrote:
> > 
> > > Sashiko flagged a few instances that could trigger out of bounds or
> > > use-after-free.  This series fixes them.
> > 
> > Hi,
> > 
> > I suppose it would be fair to credit sashiko with tags.
> > 
> > > Mario Limonciello (3):
> > >    platform/x86/amd: hfi: Fix a use-after-free when unloading the driver
> > >    platform/x86/amd: hfi: Fix out-of-bounds reads when parsing ranking
> > >      data
> > >    platform/x86/amd: hfi: Rely on ACPI enumeration instead of a dummy
> > >      device
> > > 
> > >   drivers/platform/x86/amd/hfi/hfi.c | 34 ++++++++++++++++++------------
> > >   1 file changed, 21 insertions(+), 13 deletions(-)
> > > 
> > > 
> > 
> 
> What tag would I use?  The Sashiko URLs appear to be private (or at least I
> need to be logged in).
> 
> Something like:
> 
> Reported-by: Sashiko
> 
> or
> 
> Reported-by: Sashiko
> Closes: <private-sashiko-url>

People have used:

Reported-by: Sashiko <sashiko-bot@kernel.org>
+ Closes tag

For the publically reviewed patches, the patches and their comments can be 
looked up from https://sashiko.dev . I'm not logged anywhere and can 
access at least those urls just fine. But if you for some reason cannot 
find a working link (w/o requiring login), we can just leave the Closes 
tag out.


-- 
 i.
Re: [PATCH 0/3] Fix a few Sashiko flagged issues on AMD_HFI
Posted by Mario Limonciello 3 days, 1 hour ago

On 9/21/26 12:22, Ilpo Järvinen wrote:
> On Mon, 21 Sep 2026, Mario Limonciello wrote:
>> On 9/21/26 12:10, Ilpo Järvinen wrote:
>>> On Mon, 21 Sep 2026, Mario Limonciello wrote:
>>>
>>>> Sashiko flagged a few instances that could trigger out of bounds or
>>>> use-after-free.  This series fixes them.
>>>
>>> Hi,
>>>
>>> I suppose it would be fair to credit sashiko with tags.
>>>
>>>> Mario Limonciello (3):
>>>>     platform/x86/amd: hfi: Fix a use-after-free when unloading the driver
>>>>     platform/x86/amd: hfi: Fix out-of-bounds reads when parsing ranking
>>>>       data
>>>>     platform/x86/amd: hfi: Rely on ACPI enumeration instead of a dummy
>>>>       device
>>>>
>>>>    drivers/platform/x86/amd/hfi/hfi.c | 34 ++++++++++++++++++------------
>>>>    1 file changed, 21 insertions(+), 13 deletions(-)
>>>>
>>>>
>>>
>>
>> What tag would I use?  The Sashiko URLs appear to be private (or at least I
>> need to be logged in).
>>
>> Something like:
>>
>> Reported-by: Sashiko
>>
>> or
>>
>> Reported-by: Sashiko
>> Closes: <private-sashiko-url>
> 
> People have used:
> 
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> + Closes tag
> 
> For the publically reviewed patches, the patches and their comments can be
> looked up from https://sashiko.dev . I'm not logged anywhere and can
> access at least those urls just fine. But if you for some reason cannot
> find a working link (w/o requiring login), we can just leave the Closes
> tag out.
> 
> 

I don't actually know if the URL is secret to me or if it's just anyone 
can sign into Sashiko to access it.  I'll reply with tags to each patch 
and you can decide whether to incorporate the Closes or not.