[PATCH 0/3] iomap: fix error handling regressions

Andrea Parri posted 3 patches 3 days, 11 hours ago
There is a newer version of this series
fs/iomap/direct-io.c | 11 ++++++++---
fs/iomap/fiemap.c    |  8 ++++----
fs/iomap/ioend.c     | 10 +++++++++-
3 files changed, 21 insertions(+), 8 deletions(-)
[PATCH 0/3] iomap: fix error handling regressions
Posted by Andrea Parri 3 days, 11 hours ago
Fix three independent error handling regressions in iomap:

 - clear the writeback context after a failed ->writeback_submit() call,
   preventing an already completed ioend from being submitted again;
 - preserve an iomap iteration error when iomap_fiemap() has a pending
   extent to emit; and
 - preserve a direct I/O data path error when sub-block tail zeroing
   succeeds.

The fixes have no ordering dependencies and can be applied or backported
independently.  Each issue was reproduced before and after its respective
fix.

Andrea Parri (3):
  iomap: don't resubmit an ioend after ->writeback_submit() failed
  iomap: don't lose a fiemap iteration error when emitting the last
    extent
  iomap: don't lose a failed direct I/O bio's error when zeroing the
    tail

 fs/iomap/direct-io.c | 11 ++++++++---
 fs/iomap/fiemap.c    |  8 ++++----
 fs/iomap/ioend.c     | 10 +++++++++-
 3 files changed, 21 insertions(+), 8 deletions(-)


base-commit: 93f51579e7df248780214094418f205253383cc5
-- 
2.53.0
Re: [PATCH 0/3] iomap: fix error handling regressions
Posted by Brian Foster 3 days, 1 hour ago
On Mon, Sep 21, 2026 at 10:31:30AM +0200, Andrea Parri wrote:
> Fix three independent error handling regressions in iomap:
> 
>  - clear the writeback context after a failed ->writeback_submit() call,
>    preventing an already completed ioend from being submitted again;
>  - preserve an iomap iteration error when iomap_fiemap() has a pending
>    extent to emit; and
>  - preserve a direct I/O data path error when sub-block tail zeroing
>    succeeds.
> 
> The fixes have no ordering dependencies and can be applied or backported
> independently.  Each issue was reproduced before and after its respective
> fix.
> 

These all look reasonable to me:

Reviewed-by: Brian Foster <bfoster@redhat.com>

> Andrea Parri (3):
>   iomap: don't resubmit an ioend after ->writeback_submit() failed
>   iomap: don't lose a fiemap iteration error when emitting the last
>     extent
>   iomap: don't lose a failed direct I/O bio's error when zeroing the
>     tail
> 
>  fs/iomap/direct-io.c | 11 ++++++++---
>  fs/iomap/fiemap.c    |  8 ++++----
>  fs/iomap/ioend.c     | 10 +++++++++-
>  3 files changed, 21 insertions(+), 8 deletions(-)
> 
> 
> base-commit: 93f51579e7df248780214094418f205253383cc5
> -- 
> 2.53.0
>