[PATCH 0/5] firewire: cdev: refactor for bus reset event filling

Takashi Sakamoto posted 5 patches 4 days, 12 hours ago
drivers/firewire/core-cdev.c | 63 +++++++++++++++++++++++-------------
drivers/firewire/uapi-test.c | 20 ++++++++++++
2 files changed, 60 insertions(+), 23 deletions(-)
[PATCH 0/5] firewire: cdev: refactor for bus reset event filling
Posted by Takashi Sakamoto 4 days, 12 hours ago
Hi,

In the cdev layer, there are two places where bus reset events are filed;
the update path for the associated fw_device instance and the get_info
ioctl call. There is still some code that can be refactored in these
paths.

This series refactors the code to make the memory ordering and locking
scope more explicit, and adds a KUnit test for the bus reset event UAPI
structure.

Takashi Sakamoto (5):
  firewire: cdev: use memory barrier to access fw_device members
  firewire: cdev: refactor using scoped_guard() for get_info ioctl call
  firewire: cdev: refactor copy_to_user() in get_info ioctl call
  firewire: cdev: add annotations and comments about race condition of
    bus_reset_closure
  firewire: cdev: add KUnit test for bus reset event UAPI structure

 drivers/firewire/core-cdev.c | 63 +++++++++++++++++++++++-------------
 drivers/firewire/uapi-test.c | 20 ++++++++++++
 2 files changed, 60 insertions(+), 23 deletions(-)


base-commit: a20545fbf9226591017fc371bdfb1bfd490b0e0b
-- 
2.53.0
Re: [PATCH 0/5] firewire: cdev: refactor for bus reset event filling
Posted by Takashi Sakamoto 3 days, 17 hours ago
On Sun, Sep 20, 2026 at 04:14:56PM +0900, Takashi Sakamoto wrote:
> Hi,
> 
> In the cdev layer, there are two places where bus reset events are filed;
> the update path for the associated fw_device instance and the get_info
> ioctl call. There is still some code that can be refactored in these
> paths.
> 
> This series refactors the code to make the memory ordering and locking
> scope more explicit, and adds a KUnit test for the bus reset event UAPI
> structure.
> 
> Takashi Sakamoto (5):
>   firewire: cdev: use memory barrier to access fw_device members
>   firewire: cdev: refactor using scoped_guard() for get_info ioctl call
>   firewire: cdev: refactor copy_to_user() in get_info ioctl call
>   firewire: cdev: add annotations and comments about race condition of
>     bus_reset_closure
>   firewire: cdev: add KUnit test for bus reset event UAPI structure
> 
>  drivers/firewire/core-cdev.c | 63 +++++++++++++++++++++++-------------
>  drivers/firewire/uapi-test.c | 20 ++++++++++++
>  2 files changed, 60 insertions(+), 23 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto