mm/damon/api: remove unused NR_DAMOS_* enumerators

[PATCH] mm/damon/api: remove unused NR_DAMOS_* enumerators

Posted by Zenghui Yu 4 days, 19 hours ago

From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>

NR_DAMOS_ACTIONS, NR_DAMOS_QUOTA_GOAL_METRICS, and NR_DAMOS_WMARK_METRICS
are not referenced by any code.  Remove them.

They can be reintroduced if a real user comes up.

Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
---
 include/linux/damon.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/include/linux/damon.h b/include/linux/damon.h
index 836353c4ab9a..6258ef8be764 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -117,7 +117,6 @@ struct damon_target {
  * @DAMOS_MIGRATE_HOT:  Migrate the regions prioritizing warmer regions.
  * @DAMOS_MIGRATE_COLD:	Migrate the regions prioritizing colder regions.
  * @DAMOS_STAT:		Do nothing but count the stat.
- * @NR_DAMOS_ACTIONS:	Total number of DAMOS actions
  *
  * The support of each action is up to running &struct damon_operations.
  * Refer to 'Operation Action' section of Documentation/mm/damon/design.rst for
@@ -137,7 +136,6 @@ enum damos_action {
 	DAMOS_MIGRATE_HOT,
 	DAMOS_MIGRATE_COLD,
 	DAMOS_STAT,		/* Do nothing but only record the stat */
-	NR_DAMOS_ACTIONS,
 };
 
 /**
@@ -154,9 +152,6 @@ enum damos_action {
  * @DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP:	Scheme-eligible memory ratio of a
  *					node in basis points (0-10000).
  * @DAMOS_QUOTA_HUGEPAGE_MEM_BP:	Huge page to total used memory ratio.
- * @NR_DAMOS_QUOTA_GOAL_METRICS:	Number of DAMOS quota goal metrics.
- *
- * Metrics equal to larger than @NR_DAMOS_QUOTA_GOAL_METRICS are unsupported.
  */
 enum damos_quota_goal_metric {
 	DAMOS_QUOTA_USER_INPUT,
@@ -169,7 +164,6 @@ enum damos_quota_goal_metric {
 	DAMOS_QUOTA_INACTIVE_MEM_BP,
 	DAMOS_QUOTA_NODE_ELIGIBLE_MEM_BP,
 	DAMOS_QUOTA_HUGEPAGE_MEM_BP,
-	NR_DAMOS_QUOTA_GOAL_METRICS,
 };
 
 /**
@@ -313,12 +307,10 @@ struct damos_quota {
  *
  * @DAMOS_WMARK_NONE:		Ignore the watermarks of the given scheme.
  * @DAMOS_WMARK_FREE_MEM_RATE:	Free memory rate of the system in [0,1000].
- * @NR_DAMOS_WMARK_METRICS:	Total number of DAMOS watermark metrics
  */
 enum damos_wmark_metric {
 	DAMOS_WMARK_NONE,
 	DAMOS_WMARK_FREE_MEM_RATE,
-	NR_DAMOS_WMARK_METRICS,
 };
 
 /**
-- 
2.53.0

Re: [PATCH] mm/damon/api: remove unused NR_DAMOS_* enumerators

Posted by SJ Park 4 days, 10 hours ago

On Sun, 20 Sep 2026 09:20:28 +0800 Zenghui Yu <zenghui.yu@linux.dev> wrote:

> From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
> 
> NR_DAMOS_ACTIONS, NR_DAMOS_QUOTA_GOAL_METRICS, and NR_DAMOS_WMARK_METRICS

More than 72 columns.

> are not referenced by any code.  Remove them.
> 
> They can be reintroduced if a real user comes up.
> 
> Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>

Other than the above too trivial thing,

Reviewed-by: SJ Park <sj@kernel.org>

This patch is applied to damon/next [1] tree with the fix of the trivial commit
message length issue.  If this patch is not added to mm.git in short term
(~1 week?) with the fix, I will ask mm.git maintainer (Andrew Morton) to pick
this.  So, no action from your side is needed for now.  If it seems I also
forgot doing that or you cannot wait for my action, please feel free to ping me
or Andrew.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees

Thanks,
SJ

[...]

Re: [PATCH] mm/damon/api: remove unused NR_DAMOS_* enumerators

Posted by Zenghui Yu 4 days, 8 hours ago

On 9/20/26 6:00 PM, SJ Park wrote:
> On Sun, 20 Sep 2026 09:20:28 +0800 Zenghui Yu <zenghui.yu@linux.dev> wrote:
> 
> > From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
> >
> > NR_DAMOS_ACTIONS, NR_DAMOS_QUOTA_GOAL_METRICS, and NR_DAMOS_WMARK_METRICS
> 
> More than 72 columns.

I learnt from submitting-patches.rst that

  - The body of the explanation, line wrapped at 75 columns, which will
    be copied to the permanent changelog to describe this patch.

But I'm also fine with the 72 columns rule for damon patches (or for mm
patches?).

> > are not referenced by any code.  Remove them.
> >
> > They can be reintroduced if a real user comes up.
> >
> > Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
> 
> Other than the above too trivial thing,
> 
> Reviewed-by: SJ Park <sj@kernel.org>

Thanks!

Zenghui

Re: [PATCH] mm/damon/api: remove unused NR_DAMOS_* enumerators

Posted by SJ Park 4 days, 7 hours ago

On Sun, 20 Sep 2026 20:34:48 +0800 Zenghui Yu <zenghui.yu@linux.dev> wrote:

> On 9/20/26 6:00 PM, SJ Park wrote:
> > On Sun, 20 Sep 2026 09:20:28 +0800 Zenghui Yu <zenghui.yu@linux.dev> wrote:
> > 
> > > From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
> > >
> > > NR_DAMOS_ACTIONS, NR_DAMOS_QUOTA_GOAL_METRICS, and NR_DAMOS_WMARK_METRICS
> > 
> > More than 72 columns.
> 
> I learnt from submitting-patches.rst that
> 
>   - The body of the explanation, line wrapped at 75 columns, which will
>     be copied to the permanent changelog to describe this patch.
> 
> But I'm also fine with the 72 columns rule for damon patches (or for mm
> patches?).

Ah, thank you for pointing that.  Let's use 75 columns.


Thanks,
SJ

[...]