[PATCH] octeontx2-af: remove duplicate SCTP port flags

Aryan Sinha posted 1 patch 6 days, 17 hours ago
There is a newer version of this series
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] octeontx2-af: remove duplicate SCTP port flags
Posted by Aryan Sinha 6 days, 17 hours ago
proto_flags ORs BIT_ULL(NPC_SPORT_SCTP) and BIT_ULL(NPC_DPORT_SCTP)
are present twice. Both fields are already covered by the first pair, so the second
one has no effect.

Drop it. No functional change.

Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
index d422bdd5e..ec004ea51 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
@@ -698,7 +698,6 @@ static void npc_set_features(struct rvu *rvu, int blkaddr, u8 intf)
 	proto_flags = BIT_ULL(NPC_SPORT_TCP) | BIT_ULL(NPC_SPORT_UDP) |
 		       BIT_ULL(NPC_DPORT_TCP) | BIT_ULL(NPC_DPORT_UDP) |
 		       BIT_ULL(NPC_SPORT_SCTP) | BIT_ULL(NPC_DPORT_SCTP) |
-		       BIT_ULL(NPC_SPORT_SCTP) | BIT_ULL(NPC_DPORT_SCTP) |
 		       BIT_ULL(NPC_TYPE_ICMP) | BIT_ULL(NPC_CODE_ICMP) |
 		       BIT_ULL(NPC_TCP_FLAGS);
 
-- 
2.46.0
Re: [PATCH] octeontx2-af: remove duplicate SCTP port flags
Posted by Ratheesh Kannoth 6 days, 17 hours ago
On 2026-09-18 at 11:33:19, Aryan Sinha (sinha.aryan03@gmail.com) wrote:
> proto_flags ORs BIT_ULL(NPC_SPORT_SCTP) and BIT_ULL(NPC_DPORT_SCTP)
> are present twice. Both fields are already covered by the first pair, so the second
> one has no effect.
>
> Drop it. No functional change.
>
> Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>
Isn't this a fix? Please include the appropriate Fixes tag:
Re: [PATCH] octeontx2-af: remove duplicate SCTP port flags
Posted by Jakub Kicinski 6 days, 1 hour ago
On Fri, 18 Sep 2026 11:55:08 +0530 Ratheesh Kannoth wrote:
> On 2026-09-18 at 11:33:19, Aryan Sinha (sinha.aryan03@gmail.com) wrote:
> > proto_flags ORs BIT_ULL(NPC_SPORT_SCTP) and BIT_ULL(NPC_DPORT_SCTP)
> > are present twice. Both fields are already covered by the first pair, so the second
> > one has no effect.
> >
> > Drop it. No functional change.
> >
> > Signed-off-by: Aryan Sinha <sinha.aryan03@gmail.com>  
> Isn't this a fix? Please include the appropriate Fixes tag:

The patch has no functional change, how could it be a fix?