net/mlx5e: Fix offload lifetime, cleanup and exclusion bugs

[PATCH net 0/7] net/mlx5e: Fix offload lifetime, cleanup and exclusion bugs

Posted by Tariq Toukan 1 week ago

Hi,

This series by Cosmin fixes several mlx5e offload issues:

- Block eswitch mode changes before accessing the IPsec context during
  policy and SA creation.
- Tie TC eswitch and IPsec-blocking references to flow destruction,
  covering bulk cleanup and flows with outstanding references.
- Track MACsec hardware-object ownership explicitly and delete remaining
  SecYs during driver cleanup.
- Serialize TC/IPsec exclusion counters with a dedicated mutex.
- Prevent SHAMPO from merging PSP packets.

Regards,
Tariq

Cosmin Ratiu (7):
  net/mlx5e: ipsec: Block eswitch mode changes during policy creation
  net/mlx5e: ipsec: Block eswitch mode changes before accessing
    priv->ipsec
  net/mlx5e: tc: Tie esw & accel blocking refs to the flow's lifetime
  net/mlx5e: macsec: Track hardware object ownership for SA teardown
  net/mlx5e: macsec: Delete remaining SecYs during cleanup
  net/mlx5e: Serialize TC and IPsec offload exclusion counters
  net/mlx5e: shampo: Do not merge PSP packets

 .../mellanox/mlx5/core/en_accel/ipsec.c       | 55 +++++++++++-----
 .../mellanox/mlx5/core/en_accel/ipsec_fs.c    | 47 ++++---------
 .../mellanox/mlx5/core/en_accel/macsec.c      | 60 +++++++++++------
 .../net/ethernet/mellanox/mlx5/core/en_rx.c   | 15 ++++-
 .../net/ethernet/mellanox/mlx5/core/en_tc.c   | 66 ++++++++++++-------
 .../net/ethernet/mellanox/mlx5/core/eswitch.c | 23 ++-----
 .../net/ethernet/mellanox/mlx5/core/eswitch.h | 11 ++--
 .../mellanox/mlx5/core/eswitch_offloads.c     |  7 +-
 .../net/ethernet/mellanox/mlx5/core/main.c    |  3 +
 include/linux/mlx5/driver.h                   |  7 +-
 10 files changed, 172 insertions(+), 122 deletions(-)


base-commit: c9151088f1674fd29ff26a20f5fc687acf53a2f0
-- 
2.44.0

Re: [PATCH net 0/7] net/mlx5e: Fix offload lifetime, cleanup and exclusion bugs

Posted by Paolo Abeni 2 days, 13 hours ago

On 9/17/26 19:54, Tariq Toukan wrote:
> This series by Cosmin fixes several mlx5e offload issues:
> 
> - Block eswitch mode changes before accessing the IPsec context during
>    policy and SA creation.
> - Tie TC eswitch and IPsec-blocking references to flow destruction,
>    covering bulk cleanup and flows with outstanding references.
> - Track MACsec hardware-object ownership explicitly and delete remaining
>    SecYs during driver cleanup.
> - Serialize TC/IPsec exclusion counters with a dedicated mutex.
> - Prevent SHAMPO from merging PSP packets.
Some of the clashiko findings look both legit and relevant to me.

Friendly reminder that you are expected to address them on the ML.

/P

Re: [PATCH net 0/7] net/mlx5e: Fix offload lifetime, cleanup and exclusion bugs

Posted by Cosmin Ratiu 1 day, 13 hours ago

On Thu, 2026-09-17 at 20:54 +0300, Tariq Toukan wrote:
> Hi,
> 
> This series by Cosmin fixes several mlx5e offload issues:
> 
> - Block eswitch mode changes before accessing the IPsec context
> during
>   policy and SA creation.
> - Tie TC eswitch and IPsec-blocking references to flow destruction,
>   covering bulk cleanup and flows with outstanding references.
> - Track MACsec hardware-object ownership explicitly and delete
> remaining
>   SecYs during driver cleanup.
> - Serialize TC/IPsec exclusion counters with a dedicated mutex.
> - Prevent SHAMPO from merging PSP packets.
> 
> Regards,
> Tariq
> 
> Cosmin Ratiu (7):
>   net/mlx5e: ipsec: Block eswitch mode changes during policy creation
>   net/mlx5e: ipsec: Block eswitch mode changes before accessing
>     priv->ipsec
>   net/mlx5e: tc: Tie esw & accel blocking refs to the flow's lifetime
>   net/mlx5e: macsec: Track hardware object ownership for SA teardown
>   net/mlx5e: macsec: Delete remaining SecYs during cleanup
>   net/mlx5e: Serialize TC and IPsec offload exclusion counters
>   net/mlx5e: shampo: Do not merge PSP packets
> 
>  .../mellanox/mlx5/core/en_accel/ipsec.c       | 55 +++++++++++-----
>  .../mellanox/mlx5/core/en_accel/ipsec_fs.c    | 47 ++++---------
>  .../mellanox/mlx5/core/en_accel/macsec.c      | 60 +++++++++++------
>  .../net/ethernet/mellanox/mlx5/core/en_rx.c   | 15 ++++-
>  .../net/ethernet/mellanox/mlx5/core/en_tc.c   | 66 ++++++++++++-----
> --
>  .../net/ethernet/mellanox/mlx5/core/eswitch.c | 23 ++-----
>  .../net/ethernet/mellanox/mlx5/core/eswitch.h | 11 ++--
>  .../mellanox/mlx5/core/eswitch_offloads.c     |  7 +-
>  .../net/ethernet/mellanox/mlx5/core/main.c    |  3 +
>  include/linux/mlx5/driver.h                   |  7 +-
>  10 files changed, 172 insertions(+), 122 deletions(-)
> 
> 
> base-commit: c9151088f1674fd29ff26a20f5fc687acf53a2f0

pw-bot: cr