[PATCH] mtd: Call get_wunit() on the master partition

Richard Weinberger (sigma star gmbh) posted 1 patch 1 week ago
drivers/mtd/mtdcore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] mtd: Call get_wunit() on the master partition
Posted by Richard Weinberger (sigma star gmbh) 1 week ago
From: Richard Weinberger <richard@nod.at>

The code checks whether master has get_wunit() but still calls
it on the child. Fix this.

Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling")
Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/mtd/mtdcore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 16629382a787..82b1e6392b16 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -563,7 +563,7 @@ int mtd_pairing_info_to_wunit(struct mtd_info *mtd,
 		return -EINVAL;
 
 	if (master->pairing && master->pairing->get_wunit)
-		return mtd->pairing->get_wunit(master, info);
+		return master->pairing->get_wunit(master, info);
 
 	return info->pair;
 }
-- 
2.55.0
Re: [PATCH] mtd: Call get_wunit() on the master partition
Posted by Miquel Raynal 1 week ago
On 17/09/2026 at 16:53:29 +02, "Richard Weinberger (sigma star gmbh)" <rw@kernel.org> wrote:

> From: Richard Weinberger <richard@nod.at>
>
> The code checks whether master has get_wunit() but still calls
> it on the child. Fix this.

Ha :-)

Shouldn't we add Cc: stable?

> Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling")
> Signed-off-by: Richard Weinberger <richard@nod.at>

Otherwise lgtm!

Miquèl
AW: [PATCH] mtd: Call get_wunit() on the master partition
Posted by Richard Weinberger 1 week ago
Am Thu, Sep 17, 2026, 17:14 schrieb Miquel Raynal <miquel.raynal@bootlin.com>:
> On 17/09/2026 at 16:53:29 +02, "Richard Weinberger (sigma star gmbh)" <rw@kernel.org> wrote:
> 
> > From: Richard Weinberger <richard@nod.at>
> >
> > The code checks whether master has get_wunit() but still calls
> > it on the child. Fix this.
> 
> Ha :-)
> 
> Shouldn't we add Cc: stable?

Fine by me.

Thanks,
//richard