[PATCH] firmware: imx: ele: Fix build regression

Uwe Kleine-König posted 1 patch 1 week ago
drivers/firmware/imx/ele_fw_api.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] firmware: imx: ele: Fix build regression
Posted by Uwe Kleine-König 1 week ago
At least on alpha, arc, m68k, powerpc, parisc and sh the header defining
kzalloc isn't transitively included in the driver yielding a build
failure on these architectures. Fix it by including <linux/slab.h>
explicitly.

Fixes: 7560ad03bbf4 ("firmware: imx: adds miscdev")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
Hello,

the referenced commit currently lives in next only via
https://git.kernel.org/pub/scm/linux/kernel/git/frank.li/linux.git for-next
. If that tree isn't stable, the Fixes: line might need adaption.

Best regards
Uwe

 drivers/firmware/imx/ele_fw_api.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/firmware/imx/ele_fw_api.c b/drivers/firmware/imx/ele_fw_api.c
index 42cda7de66e2..a3a68234bcb1 100644
--- a/drivers/firmware/imx/ele_fw_api.c
+++ b/drivers/firmware/imx/ele_fw_api.c
@@ -3,6 +3,8 @@
  * Copyright 2026 NXP
  */
 
+#include <linux/slab.h>
+
 #include "se_ctrl.h"
 #include "ele_common.h"
 #include "ele_fw_api.h"

base-commit: 7560ad03bbf40f5b89e210bee2dadb4be20efc1f
-- 
2.47.3

Re: [PATCH] firmware: imx: ele: Fix build regression
Posted by Frank Li 6 days, 11 hours ago
On Thu, Sep 17, 2026 at 03:22:14PM +0200, Uwe Kleine-König wrote:
> At least on alpha, arc, m68k, powerpc, parisc and sh the header defining
> kzalloc isn't transitively included in the driver yielding a build
> failure on these architectures. Fix it by including <linux/slab.h>
> explicitly.
>
> Fixes: 7560ad03bbf4 ("firmware: imx: adds miscdev")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---

thanks, squash to 7560ad03bbf4

Frank

> Hello,
>
> the referenced commit currently lives in next only via
> https://git.kernel.org/pub/scm/linux/kernel/git/frank.li/linux.git for-next
> . If that tree isn't stable, the Fixes: line might need adaption.
>
> Best regards
> Uwe
>
>  drivers/firmware/imx/ele_fw_api.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/firmware/imx/ele_fw_api.c b/drivers/firmware/imx/ele_fw_api.c
> index 42cda7de66e2..a3a68234bcb1 100644
> --- a/drivers/firmware/imx/ele_fw_api.c
> +++ b/drivers/firmware/imx/ele_fw_api.c
> @@ -3,6 +3,8 @@
>   * Copyright 2026 NXP
>   */
>
> +#include <linux/slab.h>
> +
>  #include "se_ctrl.h"
>  #include "ele_common.h"
>  #include "ele_fw_api.h"
>
> base-commit: 7560ad03bbf40f5b89e210bee2dadb4be20efc1f
> --
> 2.47.3
>