[PATCH] of/irq: Fix remaining refcount leaks in of_irq_init()

Wentao Liang posted 1 patch 1 week ago
drivers/of/irq.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] of/irq: Fix remaining refcount leaks in of_irq_init()
Posted by Wentao Liang 1 week ago
Successfully initialized controllers are moved to intc_parent_list,
but the final cleanup only frees the descriptors. The device node
references taken with of_node_get() and the interrupt parent
references are therefore leaked on the normal return path. Drop both
before kfree(), as the intc_desc_list cleanup already does.

Fixes: 8363ccb917c6 ("of/irq: add missing of_node_put")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/of/irq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 6367c67732d2..f50fec3afa2e 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -752,6 +752,8 @@ void __init of_irq_init(const struct of_device_id *matches)
 
 	list_for_each_entry_safe(desc, temp_desc, &intc_parent_list, list) {
 		list_del(&desc->list);
+		of_node_put(desc->interrupt_parent);
+		of_node_put(desc->dev);
 		kfree(desc);
 	}
 err:
-- 
2.34.1