net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests

[PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests

Posted by Karl Mehltretter 1 week ago

VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
leaves it disabled. Remove the selection, following the dependency rule
in Documentation/dev-tools/kunit/style.rst.

The debugfs implementation and its tests are already built only with
DEBUG_FS. The other VCAP tests can run without it.

Fixes: 552b7d131aa0 ("net: microchip: sparx5: Add VCAP debugfs KUNIT test")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
Validation on net c9151088f167: x86_64 LLVM builds and QEMU runs
with DEBUG_FS disabled and enabled. The other VCAP suites pass in both
configurations. The debugfs suite is present only with DEBUG_FS=y and
all four cases pass.

 drivers/net/ethernet/microchip/vcap/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/microchip/vcap/Kconfig b/drivers/net/ethernet/microchip/vcap/Kconfig
index 97f43fd4473f..1af30a358a15 100644
--- a/drivers/net/ethernet/microchip/vcap/Kconfig
+++ b/drivers/net/ethernet/microchip/vcap/Kconfig
@@ -40,7 +40,6 @@ config VCAP_KUNIT_TEST
 	bool "KUnit test for VCAP library" if !KUNIT_ALL_TESTS
 	depends on KUNIT
 	depends on KUNIT=y && VCAP=y && y
-	select DEBUG_FS
 	default KUNIT_ALL_TESTS
 	help
 	  This builds unit tests for the VCAP library.

base-commit: c9151088f1674fd29ff26a20f5fc687acf53a2f0

Re: [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests

Posted by David Gow 3 days, 18 hours ago

Le 17/09/2026 à 14:47, Karl Mehltretter a écrit :
> VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
> leaves it disabled. Remove the selection, following the dependency rule
> in Documentation/dev-tools/kunit/style.rst.
> 
> The debugfs implementation and its tests are already built only with
> DEBUG_FS. The other VCAP tests can run without it.
> 
> Fixes: 552b7d131aa0 ("net: microchip: sparx5: Add VCAP debugfs KUNIT test")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Validation on net c9151088f167: x86_64 LLVM builds and QEMU runs
> with DEBUG_FS disabled and enabled. The other VCAP suites pass in both
> configurations. The debugfs suite is present only with DEBUG_FS=y and
> all four cases pass.
> 

Acked-by: David Gow <david@davidgow.net>

Cheers,
-- David

Re: [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests

Posted by Daniel Machon 6 days, 19 hours ago

> VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
> leaves it disabled. Remove the selection, following the dependency rule
> in Documentation/dev-tools/kunit/style.rst.
> 
> The debugfs implementation and its tests are already built only with
> DEBUG_FS. The other VCAP tests can run without it.
> 
> Fixes: 552b7d131aa0 ("net: microchip: sparx5: Add VCAP debugfs KUNIT test")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Validation on net c9151088f167: x86_64 LLVM builds and QEMU runs
> with DEBUG_FS disabled and enabled. The other VCAP suites pass in both
> configurations. The debugfs suite is present only with DEBUG_FS=y and
> all four cases pass.
> 
>  drivers/net/ethernet/microchip/vcap/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/microchip/vcap/Kconfig b/drivers/net/ethernet/microchip/vcap/Kconfig
> index 97f43fd4473f..1af30a358a15 100644
> --- a/drivers/net/ethernet/microchip/vcap/Kconfig
> +++ b/drivers/net/ethernet/microchip/vcap/Kconfig
> @@ -40,7 +40,6 @@ config VCAP_KUNIT_TEST
>         bool "KUnit test for VCAP library" if !KUNIT_ALL_TESTS
>         depends on KUNIT
>         depends on KUNIT=y && VCAP=y && y
> -       select DEBUG_FS
>         default KUNIT_ALL_TESTS
>         help
>           This builds unit tests for the VCAP library.
> 
> base-commit: c9151088f1674fd29ff26a20f5fc687acf53a2f0

Reviewed-by: Daniel Machon <daniel.machon@microchip.com>