drm/tests: Fix tmp_connector reference leak in drm_test_drm_connector_dynamic_register_mode_object()

[PATCH] drm/tests: Fix tmp_connector reference leak in drm_test_drm_connector_dynamic_register_mode_object()

Wentao Liang posted 1 patch 1 week, 1 day ago

Download mbox

drivers/gpu/drm/tests/drm_connector_test.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] drm/tests: Fix tmp_connector reference leak in drm_test_drm_connector_dynamic_register_mode_object()

Posted by Wentao Liang 1 week, 1 day ago

drm_connector_lookup() takes a reference to the looked-up connector,
which the test never drops.  Release it after the lookup succeeded.

Fixes: 9ce43bba6569 ("drm/tests: Add tests for drm_connector_dynamic_init()/register()")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/gpu/drm/tests/drm_connector_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tests/drm_connector_test.c b/drivers/gpu/drm/tests/drm_connector_test.c
index beb1d50a6646..bc63e722117d 100644
--- a/drivers/gpu/drm/tests/drm_connector_test.c
+++ b/drivers/gpu/drm/tests/drm_connector_test.c
@@ -582,6 +582,7 @@ static void drm_test_drm_connector_dynamic_register_mode_object(struct kunit *te
 
 	tmp_connector = drm_connector_lookup(connector->dev, NULL, connector->base.id);
 	KUNIT_ASSERT_PTR_EQ(test, tmp_connector, connector);
+	drm_connector_put(tmp_connector);
 }
 
 /*
-- 
2.34.1