iio: addac: ad74413r: Fix trigger reference leak in ad74413r_probe()

[PATCH] iio: addac: ad74413r: Fix trigger reference leak in ad74413r_probe()

Posted by Wentao Liang 1 week, 1 day ago

The reference taken with iio_trigger_get() is only dropped by
iio_dev_release() when INDIO_BUFFER_TRIGGERED is set. Every failure
between trigger registration and the triggered buffer setup returns
before that mode is set and leaks the reference acquired for
indio_dev->trig. Move the iio_trigger_get() after the buffer setup
succeeds.

Fixes: fea251b6a5db ("iio: addac: add AD74413R driver")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/iio/addac/ad74413r.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
index fe930ce5ee30..380900bf6772 100644
--- a/drivers/iio/addac/ad74413r.c
+++ b/drivers/iio/addac/ad74413r.c
@@ -1397,7 +1397,6 @@ static int ad74413r_probe(struct spi_device *spi)
 	indio_dev->name = st->chip_info->name;
 	indio_dev->modes = INDIO_DIRECT_MODE;
 	indio_dev->info = &ad74413r_info;
-	indio_dev->trig = iio_trigger_get(st->trig);
 
 	ret = ad74413r_reset(st);
 	if (ret)
@@ -1467,6 +1466,8 @@ static int ad74413r_probe(struct spi_device *spi)
 	if (ret)
 		return ret;
 
+	indio_dev->trig = iio_trigger_get(st->trig);
+
 	return devm_iio_device_register(st->dev, indio_dev);
 }
 
-- 
2.34.1

Re: [PATCH] iio: addac: ad74413r: Fix trigger reference leak in ad74413r_probe()

Posted by Jonathan Cameron 1 week, 1 day ago

On Wed, 16 Sep 2026 16:22:51 +0000
Wentao Liang <vulab@iscas.ac.cn> wrote:

> The reference taken with iio_trigger_get() is only dropped by
> iio_dev_release() when INDIO_BUFFER_TRIGGERED is set. Every failure
> between trigger registration and the triggered buffer setup returns
> before that mode is set and leaks the reference acquired for
> indio_dev->trig. Move the iio_trigger_get() after the buffer setup
> succeeds.
> 
> Fixes: fea251b6a5db ("iio: addac: add AD74413R driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Not this solution.  For anyone interested see other replies to similar patches.

> ---
>  drivers/iio/addac/ad74413r.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
> index fe930ce5ee30..380900bf6772 100644
> --- a/drivers/iio/addac/ad74413r.c
> +++ b/drivers/iio/addac/ad74413r.c
> @@ -1397,7 +1397,6 @@ static int ad74413r_probe(struct spi_device *spi)
>  	indio_dev->name = st->chip_info->name;
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  	indio_dev->info = &ad74413r_info;
> -	indio_dev->trig = iio_trigger_get(st->trig);
>  
>  	ret = ad74413r_reset(st);
>  	if (ret)
> @@ -1467,6 +1466,8 @@ static int ad74413r_probe(struct spi_device *spi)
>  	if (ret)
>  		return ret;
>  
> +	indio_dev->trig = iio_trigger_get(st->trig);
> +
>  	return devm_iio_device_register(st->dev, indio_dev);
>  }
>