[PATCH] Documentation: net: dsa: Fix bracket

Manuel Ebner posted 1 patch 1 week, 1 day ago
Documentation/networking/dsa/dsa.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] Documentation: net: dsa: Fix bracket
Posted by Manuel Ebner 1 week, 1 day ago
Add missing ')'.

Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
 Documentation/networking/dsa/dsa.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/networking/dsa/dsa.rst b/Documentation/networking/dsa/dsa.rst
index 42a99f5df..7edfdd555 100644
--- a/Documentation/networking/dsa/dsa.rst
+++ b/Documentation/networking/dsa/dsa.rst
@@ -864,7 +864,7 @@ The drivers which act upon the ``dsa_db`` argument in ``port_fdb_add``,
 DSA associates each offloaded bridge and each offloaded LAG with a one-based ID
 (``struct dsa_bridge :: num``, ``struct dsa_lag :: id``) for the purposes of
 refcounting addresses on shared ports. Drivers may piggyback on DSA's numbering
-scheme (the ID is readable through ``db->bridge.num`` and ``db->lag.id`` or may
+scheme (the ID is readable through ``db->bridge.num`` and ``db->lag.id``) or may
 implement their own.
 
 Only the drivers which declare support for FDB isolation are notified of FDB
-- 
2.55.0
Re: [PATCH] Documentation: net: dsa: Fix bracket
Posted by Randy Dunlap 1 week, 1 day ago

On 9/16/26 5:34 AM, Manuel Ebner wrote:
> Add missing ')'.
> 
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.

> ---
>  Documentation/networking/dsa/dsa.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/networking/dsa/dsa.rst b/Documentation/networking/dsa/dsa.rst
> index 42a99f5df..7edfdd555 100644
> --- a/Documentation/networking/dsa/dsa.rst
> +++ b/Documentation/networking/dsa/dsa.rst
> @@ -864,7 +864,7 @@ The drivers which act upon the ``dsa_db`` argument in ``port_fdb_add``,
>  DSA associates each offloaded bridge and each offloaded LAG with a one-based ID
>  (``struct dsa_bridge :: num``, ``struct dsa_lag :: id``) for the purposes of
>  refcounting addresses on shared ports. Drivers may piggyback on DSA's numbering
> -scheme (the ID is readable through ``db->bridge.num`` and ``db->lag.id`` or may
> +scheme (the ID is readable through ``db->bridge.num`` and ``db->lag.id``) or may
>  implement their own.
>  
>  Only the drivers which declare support for FDB isolation are notified of FDB

-- 
~Randy
[PATCH] scsi: docs: aic: Fix brackets
Posted by Manuel Ebner 1 week, 1 day ago
Add missing '}' to lines of code.

Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
Would it be better to remove the '{' and replace '{{'/'}}' with '{'/'}'?
---
 Documentation/scsi/aic79xx.rst | 2 +-
 Documentation/scsi/aic7xxx.rst | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/scsi/aic79xx.rst b/Documentation/scsi/aic79xx.rst
index 071ff5111..ba5299cb9 100644
--- a/Documentation/scsi/aic79xx.rst
+++ b/Documentation/scsi/aic79xx.rst
@@ -292,7 +292,7 @@ tag_info:{{value[,value...]}[,{value[,value...]}...]}
 
 	::
 
-	    tag_info:{{16,32,32,64,8,8,,32,32,32,32,32,32,32,32,32}
+	    tag_info:{{16,32,32,64,8,8,,32,32,32,32,32,32,32,32,32}}
 
 	On Controller 0
 
diff --git a/Documentation/scsi/aic7xxx.rst b/Documentation/scsi/aic7xxx.rst
index bad0e5567..117cd55fd 100644
--- a/Documentation/scsi/aic7xxx.rst
+++ b/Documentation/scsi/aic7xxx.rst
@@ -308,7 +308,7 @@ tag_info:{{value[,value...]}[,{value[,value...]}...]}
 
 	    ::
 
-	        tag_info:{{16,32,32,64,8,8,,32,32,32,32,32,32,32,32,32}
+	        tag_info:{{16,32,32,64,8,8,,32,32,32,32,32,32,32,32,32}}
 
 	    On Controller 0:
 
-- 
2.55.0
Re: [PATCH] scsi: docs: aic: Fix brackets
Posted by Randy Dunlap 1 week, 1 day ago

On 9/16/26 5:35 AM, Manuel Ebner wrote:
> Add missing '}' to lines of code.
> 
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
> Would it be better to remove the '{' and replace '{{'/'}}' with '{'/'}'?

Not IMO. Looks to me like the patch now matches the definition
of tag_info.

> ---
>  Documentation/scsi/aic79xx.rst | 2 +-
>  Documentation/scsi/aic7xxx.rst | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/scsi/aic79xx.rst b/Documentation/scsi/aic79xx.rst
> index 071ff5111..ba5299cb9 100644
> --- a/Documentation/scsi/aic79xx.rst
> +++ b/Documentation/scsi/aic79xx.rst
> @@ -292,7 +292,7 @@ tag_info:{{value[,value...]}[,{value[,value...]}...]}
>  
>  	::
>  
> -	    tag_info:{{16,32,32,64,8,8,,32,32,32,32,32,32,32,32,32}
> +	    tag_info:{{16,32,32,64,8,8,,32,32,32,32,32,32,32,32,32}}
>  
>  	On Controller 0
>  
> diff --git a/Documentation/scsi/aic7xxx.rst b/Documentation/scsi/aic7xxx.rst
> index bad0e5567..117cd55fd 100644
> --- a/Documentation/scsi/aic7xxx.rst
> +++ b/Documentation/scsi/aic7xxx.rst
> @@ -308,7 +308,7 @@ tag_info:{{value[,value...]}[,{value[,value...]}...]}
>  
>  	    ::
>  
> -	        tag_info:{{16,32,32,64,8,8,,32,32,32,32,32,32,32,32,32}
> +	        tag_info:{{16,32,32,64,8,8,,32,32,32,32,32,32,32,32,32}}
>  
>  	    On Controller 0:
>  

-- 
~Randy
[PATCH] docs: networking: radiotap: Fix bracket
Posted by Manuel Ebner 1 week, 1 day ago
Remove needless ')' from code.

Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
 Documentation/networking/radiotap-headers.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/networking/radiotap-headers.rst b/Documentation/networking/radiotap-headers.rst
index 1a1bd1ec0..aadc7bc6b 100644
--- a/Documentation/networking/radiotap-headers.rst
+++ b/Documentation/networking/radiotap-headers.rst
@@ -133,7 +133,7 @@ its prototypes available in include/net/cfg80211.h.  You use it like this::
 
 		    case IEEE80211_RADIOTAP_ANTENNA:
 			    /* radiotap uses 0 for 1st ant */
-			    antenna = *iterator.this_arg);
+			    antenna = *iterator.this_arg;
 			    break;
 
 		    case IEEE80211_RADIOTAP_DBM_TX_POWER:
-- 
2.55.0
Re: [PATCH] docs: networking: radiotap: Fix bracket
Posted by Randy Dunlap 1 week, 1 day ago

On 9/16/26 5:34 AM, Manuel Ebner wrote:
> Remove needless ')' from code.
> 
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>  Documentation/networking/radiotap-headers.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/networking/radiotap-headers.rst b/Documentation/networking/radiotap-headers.rst
> index 1a1bd1ec0..aadc7bc6b 100644
> --- a/Documentation/networking/radiotap-headers.rst
> +++ b/Documentation/networking/radiotap-headers.rst
> @@ -133,7 +133,7 @@ its prototypes available in include/net/cfg80211.h.  You use it like this::
>  
>  		    case IEEE80211_RADIOTAP_ANTENNA:
>  			    /* radiotap uses 0 for 1st ant */
> -			    antenna = *iterator.this_arg);
> +			    antenna = *iterator.this_arg;
>  			    break;
>  
>  		    case IEEE80211_RADIOTAP_DBM_TX_POWER:

-- 
~Randy
[PATCH] docs: ethtool: Fix bracket
Posted by Manuel Ebner 1 week, 1 day ago
Add missing ')' to sentence.

Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
 Documentation/networking/ethtool-netlink.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
index e92abf45f..393f2b6d3 100644
--- a/Documentation/networking/ethtool-netlink.rst
+++ b/Documentation/networking/ethtool-netlink.rst
@@ -131,7 +131,7 @@ For compact form, ``ETHTOOL_A_BITSET_SIZE`` and ``ETHTOOL_A_BITSET_VALUE`` are
 mandatory. ``ETHTOOL_A_BITSET_MASK`` attribute is mandatory if
 ``ETHTOOL_A_BITSET_NOMASK`` is not set (bitset represents a value/mask pair);
 if ``ETHTOOL_A_BITSET_NOMASK`` is not set, ``ETHTOOL_A_BITSET_MASK`` is not
-allowed (bitset represents a single bitmap.
+allowed (bitset represents a single bitmap).
 
 Kernel bit set length may differ from userspace length if older application is
 used on newer kernel or vice versa. If userspace bitmap is longer, an error is
-- 
2.55.0
Re: [PATCH] docs: ethtool: Fix bracket
Posted by Andrew Lunn 1 week, 1 day ago
On Wed, Sep 16, 2026 at 02:34:55PM +0200, Manuel Ebner wrote:
> Add missing ')' to sentence.
> 
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew