usb: fotg210: fix USB_EHCI_HCD dependency

[PATCH] usb: fotg210: fix USB_EHCI_HCD dependency

Posted by Arnd Bergmann 1 week, 1 day ago

From: Arnd Bergmann <arnd@arndb.de>

When EHCI is a loadable module, the fotg210 HCD code cannot
be built-in:

s390-linux-ld: drivers/usb/fotg210/fotg210-hcd.o: in function `fotg210_hcd_reset':
fotg210-hcd.c:(.text+0x102): undefined reference to `ehci_setup'

Fix this using the same type of dependency that is already
used for the USB host support.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/usb/fotg210/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/fotg210/Kconfig b/drivers/usb/fotg210/Kconfig
index 2c6e76faac64..b7f0b78be7a3 100644
--- a/drivers/usb/fotg210/Kconfig
+++ b/drivers/usb/fotg210/Kconfig
@@ -16,7 +16,7 @@ if USB_FOTG210
 config USB_FOTG210_HCD
 	bool "Faraday FOTG210 USB Host Controller support"
 	depends on USB=y || USB=USB_FOTG210
-	depends on USB_EHCI_HCD
+	depends on USB_EHCI_HCD=y || USB_EHCI_HCD=USB_FOTG210
 	select USB_EHCI_DEVIANT_PORT_STATUS_REG
 	select USB_EHCI_PORT_RESET_HOOKS
 	select USB_EHCI_PORT_SPEED_HOOK
-- 
2.53.0

Re: [PATCH] usb: fotg210: fix USB_EHCI_HCD dependency

Posted by Linus Walleij 1 week, 1 day ago

On Wed, Sep 16, 2026 at 1:44 PM Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> When EHCI is a loadable module, the fotg210 HCD code cannot
> be built-in:
>
> s390-linux-ld: drivers/usb/fotg210/fotg210-hcd.o: in function `fotg210_hcd_reset':
> fotg210-hcd.c:(.text+0x102): undefined reference to `ehci_setup'
>
> Fix this using the same type of dependency that is already
> used for the USB host support.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Oh the usual Kconfig tripwire. Thanks Arnd!
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij