EDAC/x38: Fix mci_pdev reference leak in x38_init_one()

[PATCH] EDAC/x38: Fix mci_pdev reference leak in x38_init_one()

Posted by Wentao Liang 1 week, 1 day ago

In x38_init_one(), a reference to the PCI device is taken with
pci_dev_get() and stored in the global mci_pdev even when x38_probe1()
fails.  On that path x38_registered keeps its initial value of 1, so
x38_exit() skips the pci_dev_put() and the reference is leaked.

Only take the reference after x38_probe1() succeeds.

Fixes: df8bc08c192f ("edac x38: new MC driver module")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/edac/x38_edac.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
index 292dda754c23..9c6542c4e3ee 100644
--- a/drivers/edac/x38_edac.c
+++ b/drivers/edac/x38_edac.c
@@ -423,10 +423,13 @@ static int x38_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		return -EIO;
 
 	rc = x38_probe1(pdev, ent->driver_data);
+	if (rc)
+		return rc;
+
 	if (!mci_pdev)
 		mci_pdev = pci_dev_get(pdev);
 
-	return rc;
+	return 0;
 }
 
 static void x38_remove_one(struct pci_dev *pdev)
-- 
2.34.1

Re: [PATCH] EDAC/x38: Fix mci_pdev reference leak in x38_init_one()

Posted by Borislav Petkov 5 days, 23 hours ago

On Wed, Sep 16, 2026 at 09:21:21AM +0000, Wentao Liang wrote:
> In x38_init_one(), a reference to the PCI device is taken with
> pci_dev_get() and stored in the global mci_pdev even when x38_probe1()
> fails.  On that path x38_registered keeps its initial value of 1, so
> x38_exit() skips the pci_dev_put() and the reference is leaked.
> 
> Only take the reference after x38_probe1() succeeds.
> 
> Fixes: df8bc08c192f ("edac x38: new MC driver module")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/edac/x38_edac.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/x38_edac.c b/drivers/edac/x38_edac.c
> index 292dda754c23..9c6542c4e3ee 100644
> --- a/drivers/edac/x38_edac.c
> +++ b/drivers/edac/x38_edac.c
> @@ -423,10 +423,13 @@ static int x38_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  		return -EIO;
>  
>  	rc = x38_probe1(pdev, ent->driver_data);
> +	if (rc)
> +		return rc;
> +
>  	if (!mci_pdev)
>  		mci_pdev = pci_dev_get(pdev);
>  
> -	return rc;
> +	return 0;
>  }
>  
>  static void x38_remove_one(struct pci_dev *pdev)
> -- 

We just orphaned this driver but it has been practically an orphan a long time
ago already.

No need to send fixes for it.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette