In i3000_init_one(), a reference to the PCI device is taken with
pci_dev_get() and stored in the global mci_pdev even when
i3000_probe1() fails. On that path i3000_registered keeps its initial
value of 1, so i3000_exit() skips the pci_dev_put() and the reference
is leaked.
Only take the reference after i3000_probe1() succeeds.
Fixes: 535c6a53035d ("drivers/edac: new inte 30x0 MC driver")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/edac/i3000_edac.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/i3000_edac.c b/drivers/edac/i3000_edac.c
index 9065bc4386ff..d4ee6e185c80 100644
--- a/drivers/edac/i3000_edac.c
+++ b/drivers/edac/i3000_edac.c
@@ -461,10 +461,13 @@ static int i3000_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
return -EIO;
rc = i3000_probe1(pdev, ent->driver_data);
+ if (rc)
+ return rc;
+
if (!mci_pdev)
mci_pdev = pci_dev_get(pdev);
- return rc;
+ return 0;
}
static void i3000_remove_one(struct pci_dev *pdev)
--
2.34.1