irqchip/qcom-pdc: fix linking against QCOM_SCM firmware

[PATCH] irqchip/qcom-pdc: fix linking against QCOM_SCM firmware

Posted by Arnd Bergmann 1 week, 2 days ago

From: Arnd Bergmann <arnd@arndb.de>

Build testing with SCM disabled or in a loadable module fails
with a link error:

s390-linux-ld: drivers/irqchip/qcom-pdc.o: in function `qcom_pdc_probe':
qcom-pdc.c:(.text+0x18b8): undefined reference to `qcom_scm_is_available'
qcom-pdc.c:(.text+0x18ce): undefined reference to `qcom_scm_io_writel'

As QCOM_SCM can already be enabled for compile testing on non-qualcomm
machines, but is always enabled on Qualcomm Arm kernels, use that
as the Kconfig dependency and remove the ||COMPILE_TEST check.

Fixes: 1b852de05f74 ("irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM")
Fixes: ad01c2b2f291 ("irqchip/qcom-pdc: Configure PDC to pass through mode")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 89805bd0bd3e..039eaf086245 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -526,7 +526,7 @@ config GOLDFISH_PIC
 
 config QCOM_PDC
 	tristate "Qualcomm PDC"
-	depends on ARCH_QCOM || COMPILE_TEST
+	depends on QCOM_SCM
 	select IRQ_DOMAIN_HIERARCHY
 	default ARCH_QCOM
 	help
-- 
2.53.0

Re: [PATCH] irqchip/qcom-pdc: fix linking against QCOM_SCM firmware

Posted by Krzysztof Kozlowski 1 week, 2 days ago

On 15/09/2026 21:59, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Build testing with SCM disabled or in a loadable module fails
> with a link error:
> 
> s390-linux-ld: drivers/irqchip/qcom-pdc.o: in function `qcom_pdc_probe':
> qcom-pdc.c:(.text+0x18b8): undefined reference to `qcom_scm_is_available'
> qcom-pdc.c:(.text+0x18ce): undefined reference to `qcom_scm_io_writel'
> 
> As QCOM_SCM can already be enabled for compile testing on non-qualcomm
> machines, but is always enabled on Qualcomm Arm kernels, use that
> as the Kconfig dependency and remove the ||COMPILE_TEST check.
> 
> Fixes: 1b852de05f74 ("irqchip/qcom: Enable compile testing for QCOM_PDC and QCOM_MPM")
> Fixes: ad01c2b2f291 ("irqchip/qcom-pdc: Configure PDC to pass through mode")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof