[PATCH] x86/resctrl: Update documented unit for the "activity" event

Tony Luck posted 1 patch 1 week, 2 days ago
Documentation/filesystems/resctrl.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] x86/resctrl: Update documented unit for the "activity" event
Posted by Tony Luck 1 week, 2 days ago
The unit for the AET (Application Energy Telemetry) activity event[1] is nF, not F.

Fixes: a8848c4b43ad ("x86,fs/resctrl: Update documentation for telemetry events")
Signed-off-by: Tony Luck <tony.luck@intel.com>
Link: https://github.com/intel/Intel-PMT/blob/main/xml/CWF/OOBMSM/RMID-ENERGY/cwf_common.xml#L9 # [1]
---
 Documentation/filesystems/resctrl.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
index e4b66af55ffb..a52cd812c261 100644
--- a/Documentation/filesystems/resctrl.rst
+++ b/Documentation/filesystems/resctrl.rst
@@ -643,7 +643,7 @@ When monitoring is enabled all MON groups will also contain:
 	during execution of instructions summed across all logical CPUs on a
 	package for the current monitoring group.
 
-	"activity" also reports a floating point value (in Farads).  This provides
+	"activity" also reports a floating point value (in nanofarads).  This provides
 	an estimate of work done independent of the frequency that the CPUs used
 	for execution.
 
-- 
2.55.0
Re: [PATCH] x86/resctrl: Update documented unit for the "activity" event
Posted by Reinette Chatre 8 hours ago
Dear x86 maintainers,

Could you please consider this patch for inclusion?

Thank you very much.

Reinette

On 9/15/26 12:04 PM, Tony Luck wrote:
> The unit for the AET (Application Energy Telemetry) activity event[1] is nF, not F.
> 
> Fixes: a8848c4b43ad ("x86,fs/resctrl: Update documentation for telemetry events")
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Link: https://github.com/intel/Intel-PMT/blob/main/xml/CWF/OOBMSM/RMID-ENERGY/cwf_common.xml#L9 # [1]
> ---
>  Documentation/filesystems/resctrl.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
> index e4b66af55ffb..a52cd812c261 100644
> --- a/Documentation/filesystems/resctrl.rst
> +++ b/Documentation/filesystems/resctrl.rst
> @@ -643,7 +643,7 @@ When monitoring is enabled all MON groups will also contain:
>  	during execution of instructions summed across all logical CPUs on a
>  	package for the current monitoring group.
>  
> -	"activity" also reports a floating point value (in Farads).  This provides
> +	"activity" also reports a floating point value (in nanofarads).  This provides
>  	an estimate of work done independent of the frequency that the CPUs used
>  	for execution.
>
Re: [PATCH] x86/resctrl: Update documented unit for the "activity" event
Posted by Reinette Chatre 1 week, 1 day ago
Hi Tony,

On 9/15/26 12:04 PM, Tony Luck wrote:
> The unit for the AET (Application Energy Telemetry) activity event[1] is nF, not F.
> 
> Fixes: a8848c4b43ad ("x86,fs/resctrl: Update documentation for telemetry events")

Should this go to stable?

> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Link: https://github.com/intel/Intel-PMT/blob/main/xml/CWF/OOBMSM/RMID-ENERGY/cwf_common.xml#L9 # [1]
> ---
>  Documentation/filesystems/resctrl.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
> index e4b66af55ffb..a52cd812c261 100644
> --- a/Documentation/filesystems/resctrl.rst
> +++ b/Documentation/filesystems/resctrl.rst
> @@ -643,7 +643,7 @@ When monitoring is enabled all MON groups will also contain:
>  	during execution of instructions summed across all logical CPUs on a
>  	package for the current monitoring group.
>  
> -	"activity" also reports a floating point value (in Farads).  This provides
> +	"activity" also reports a floating point value (in nanofarads).  This provides
>  	an estimate of work done independent of the frequency that the CPUs used
>  	for execution.
>  

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette
RE: [PATCH] x86/resctrl: Update documented unit for the "activity" event
Posted by Luck, Tony 1 week, 1 day ago
> > The unit for the AET (Application Energy Telemetry) activity event[1] is nF, not F.
> >
> > Fixes: a8848c4b43ad ("x86,fs/resctrl: Update documentation for telemetry events")
>
> Should this go to stable?

Possibly. Though I'm not sure it would really help anyone. I don't expect anyone to change
anything based on the units here. Anyone who was using "activity" to monitor changes in
power consumption resulting from changes to their code would just have compared the
before/after values. Knowing that both numbers are nF rather than F wouldn't change
anything.

> > Signed-off-by: Tony Luck <tony.luck@intel.com>
> > Link: https://github.com/intel/Intel-PMT/blob/main/xml/CWF/OOBMSM/RMID-ENERGY/cwf_common.xml#L9 # [1]

-Tony