taskstats: drop the unused CPU_DONT_CARE enum member

[PATCH] taskstats: drop the unused CPU_DONT_CARE enum member

Posted by Bradley Morgan 1 week, 2 days ago

CPU_DONT_CARE was added by the original listener cpumask code in 2006
(f9fd8914c1ac) and has never had a single user, not even in the
commit that introduced it. It survived every refactor of the listener
path since, including the recent handler folds.

Kill it, twenty years is enough.

Signed-off-by: Bradley Morgan <brads@mainlining.org>
---
 kernel/taskstats.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/taskstats.c b/kernel/taskstats.c
index 598d9cd83250..3997dbb5aead 100644
--- a/kernel/taskstats.c
+++ b/kernel/taskstats.c
@@ -59,8 +59,7 @@ static DEFINE_PER_CPU(struct listener_list, listener_array);
 
 enum actions {
 	REGISTER,
-	DEREGISTER,
-	CPU_DONT_CARE
+	DEREGISTER
 };
 
 static int prepare_reply(struct genl_info *info, u8 cmd, struct sk_buff **skbp,
-- 
2.47.3

Re: [PATCH] taskstats: drop the unused CPU_DONT_CARE enum member

Posted by Balbir Singh 1 week, 2 days ago

On 9/16/26 4:06 AM, Bradley Morgan wrote:
> CPU_DONT_CARE was added by the original listener cpumask code in 2006
> (f9fd8914c1ac) and has never had a single user, not even in the
> commit that introduced it. It survived every refactor of the listener
> path since, including the recent handler folds.
> 
> Kill it, twenty years is enough.
> 
> Signed-off-by: Bradley Morgan <brads@mainlining.org>
> ---
>  kernel/taskstats.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/taskstats.c b/kernel/taskstats.c
> index 598d9cd83250..3997dbb5aead 100644
> --- a/kernel/taskstats.c
> +++ b/kernel/taskstats.c
> @@ -59,8 +59,7 @@ static DEFINE_PER_CPU(struct listener_list, listener_array);
>  
>  enum actions {
>  	REGISTER,
> -	DEREGISTER,
> -	CPU_DONT_CARE
> +	DEREGISTER
>  };
>  
>  static int prepare_reply(struct genl_info *info, u8 cmd, struct sk_buff **skbp,

Makes sense! Thanks for catching this

Reviewed-by: Balbir Singh <balbirs@nvidia.com>