ALSA: pcm: Simplify success check in snd_pcm_open_file()

[PATCH] ALSA: pcm: Simplify success check in snd_pcm_open_file()

Posted by phucduc.bui@gmail.com 1 week, 4 days ago

From: bui duc phuc <phucduc.bui@gmail.com>

snd_pcm_open_file() returns zero on success and a negative error code
on failure. Use !err to check for a successful return instead of
checking for a non-negative value.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 sound/core/pcm_native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 62324282fcae..000e926a1e6a 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -2930,7 +2930,7 @@ static int snd_pcm_open(struct file *file, struct snd_pcm *pcm, int stream)
 	mutex_lock(&pcm->open_mutex);
 	while (1) {
 		err = snd_pcm_open_file(file, pcm, stream);
-		if (err >= 0)
+		if (!err)
 			break;
 		if (err == -EAGAIN) {
 			if (file->f_flags & O_NONBLOCK) {
-- 
2.43.0

Re: [PATCH] ALSA: pcm: Simplify success check in snd_pcm_open_file()

Posted by Takashi Iwai 1 week, 3 days ago

On Mon, 14 Sep 2026 11:52:48 +0200,
phucduc.bui@gmail.com wrote:
> 
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> snd_pcm_open_file() returns zero on success and a negative error code
> on failure. Use !err to check for a successful return instead of
> checking for a non-negative value.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

Applied to for-next branch now.  Thanks.


Takashi