[PATCH net-next v3 0/2] selftests: net: Exercise TCP payload verification

shuo huang posted 2 patches 1 week, 4 days ago
tools/testing/selftests/net/udpgso_bench.sh   | 35 +++++++++++++
tools/testing/selftests/net/udpgso_bench_rx.c | 51 +++++++++++++++----
2 files changed, 77 insertions(+), 9 deletions(-)
[PATCH net-next v3 0/2] selftests: net: Exercise TCP payload verification
Posted by shuo huang 1 week, 4 days ago
This series adds TCP payload verification to udpgso_bench_rx and
exercises it from udpgso_bench.sh for both IPv4 and IPv6. The test
checks the receiver's exit status so that verification errors are
reported as test failures.

Changes since v2:
- Wrap the receiver command in patch 2 to stay within 80 columns.

v2: https://lore.kernel.org/r/20260911160649.51863-1-f64116045@gs.ncku.edu.tw

Changes since v1:
- Add patch 2 to exercise the TCP verifier from udpgso_bench.sh,
  addressing Jakub's feedback.

v1: https://lore.kernel.org/r/20260906145643.219609-1-f64116045@gs.ncku.edu.tw

Testing (v2):
- udpgso_bench.sh: PASS=22 SKIP=0 FAIL=0.

No full kernel build or boot of a patched net-next kernel was performed.

shuo huang (2):
  selftests: net: Add TCP payload verification to udpgso_bench_rx
  selftests: net: Exercise TCP payload verification in udpgso_bench.sh

 tools/testing/selftests/net/udpgso_bench.sh   | 35 +++++++++++++
 tools/testing/selftests/net/udpgso_bench_rx.c | 51 +++++++++++++++----
 2 files changed, 77 insertions(+), 9 deletions(-)


base-commit: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72
-- 
2.34.1
Re: [PATCH net-next v3 0/2] selftests: net: Exercise TCP payload verification
Posted by Paolo Abeni 1 week, 1 day ago
On 9/14/26 02:45, shuo huang wrote:
> This series adds TCP payload verification to udpgso_bench_rx and
> exercises it from udpgso_bench.sh for both IPv4 and IPv6. The test
> checks the receiver's exit status so that verification errors are
> reported as test failures.
> 
> Changes since v2:
> - Wrap the receiver command in patch 2 to stay within 80 columns.
> 
> v2: https://lore.kernel.org/r/20260911160649.51863-1-f64116045@gs.ncku.edu.tw
> 
> Changes since v1:
> - Add patch 2 to exercise the TCP verifier from udpgso_bench.sh,
>    addressing Jakub's feedback.

I think you did not answer the more fundamental question there: why is 
this useful? I don't see much value on top of the existing GRO (h/w) 
tests, while this add a bunch of testscase/runtime/resource usage on the 
CI from now on.

In the current format it's IMHO not worth merging.
/P