[PATCH] platform/x86: hp-wmi: Add support for HP Laptop 15-fd1xxx (board 8DE1)

Walid Elonok posted 1 patch 1 week, 5 days ago
drivers/platform/x86/hp/hp-wmi.c | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] platform/x86: hp-wmi: Add support for HP Laptop 15-fd1xxx (board 8DE1)
Posted by Walid Elonok 1 week, 5 days ago
On the HP Laptop 15-fd1xxx (motherboard ID 8DE1), hp-wmi currently falls
back to the legacy HPWMI_FAN_SPEED_GET_QUERY (0x11) command because the
board is not listed in hp_wmi_feature_boards[].

In HP BIOS DSDT table (e.g. BIOS F.26), method GM11 (query 0x11) is a
dummy stub that returns 4 bytes of 0x00 with return code 0 (success),
causing the driver to report 0 RPM via hwmon even while the fan is
actively spinning.

However, the DSDT implements method GM2D (query 0x2D / Victus S fan
interface), which reads the active fan tachometer directly from the
Embedded Controller (EC0) registers RPM1/RPM2 and reports accurate fan
speed.

Add board ID "8DE1" to hp_wmi_feature_boards[] mapped to
victus_s_board_params so hp-wmi uses the working query 0x2D interface.

Signed-off-by: Walid Elonok <walidelonk@gmail.com>
---
 drivers/platform/x86/hp/hp-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
index b2773fc1a..fd9189420 100644
--- a/drivers/platform/x86/hp/hp-wmi.c
+++ b/drivers/platform/x86/hp/hp-wmi.c
@@ -339,6 +339,10 @@ static const struct dmi_system_id hp_wmi_feature_boards[] __initconst = {
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8DD6") },
 		.driver_data = (void *)&omen_v1_no_ec_thermal_params,
 	},
+	{
+		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8DE1") },
+		.driver_data = (void *)&victus_s_board_params,
+	},
 	{
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8E35") },
 		.driver_data = (void *)&omen_v1_legacy_board_params,
-- 
2.43.0
Re: [PATCH] platform/x86: hp-wmi: Add support for HP Laptop 15-fd1xxx (board 8DE1)
Posted by Ilpo Järvinen 6 days, 16 hours ago
On Sun, 13 Sep 2026 06:46:45 +0100, Walid Elonok wrote:

> On the HP Laptop 15-fd1xxx (motherboard ID 8DE1), hp-wmi currently falls
> back to the legacy HPWMI_FAN_SPEED_GET_QUERY (0x11) command because the
> board is not listed in hp_wmi_feature_boards[].
> 
> In HP BIOS DSDT table (e.g. BIOS F.26), method GM11 (query 0x11) is a
> dummy stub that returns 4 bytes of 0x00 with return code 0 (success),
> causing the driver to report 0 RPM via hwmon even while the fan is
> actively spinning.
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/1] platform/x86: hp-wmi: Add support for HP Laptop 15-fd1xxx (board 8DE1)
      commit: 850188bb14416b0fa1956f94c79324a0d50f9a60

--
 i.