The MPQ4210 series was applied to for-7.4 as e3c05a881fc9 and 61879d561e91,
and two review comments arrived afterwards. Both are addressed here as
incremental patches against current for-7.4.
Patches 1 and 2 rename mps,fb-voltage-divider to mps,fb-voltage-divider-ohms,
as Krzysztof asked. The split across the binding and the driver leaves one
commit where the two disagree, so they are meant to be applied together. The
suffix is worth more here than the convention alone: mps,mp886x.yaml already
describes a property of the same name whose values are kilo ohms rather than
ohms, so two bindings from the same vendor spelled the resistances
identically while meaning different units. Nothing in tree uses the old name
and it has not appeared in a release, so no fallback is kept.
Patch 3 drops the <linux/mod_devicetable.h> include, as Uwe asked.
Tested on an i.MX6SX board whose MPQ4210 sits behind a gpio i2c mux, with the
device tree updated to the new property name. The regulator registers and the
divider is parsed correctly: the board sets regulator-ramp-delay above every
supported rate, and the core reports "Can't set ramp-delay 3000, setting 2101",
where 2101 uV/us is the fastest reference rate scaled by this board's divider.
That value can only be reached by reading both resistors from the renamed
property.
Signed-off-by: Tapio Reijonen <tapio.reijonen@vaisala.com>
---
Tapio Reijonen (3):
regulator: dt-bindings: mps,mpq4210: Use the -ohms unit suffix
regulator: mpq4210: Use the -ohms feedback divider property
regulator: mpq4210: Drop the mod_devicetable.h include
Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml | 9 ++++-----
drivers/regulator/mpq4210.c | 6 +++---
2 files changed, 7 insertions(+), 8 deletions(-)
---
base-commit: a655daad54efa1e3959cd642706eb81c9ebafc66
change-id: 20260913-mpq4210-ohms-fixup-8d4c0757da40
Best regards,
--
Tapio Reijonen <tapio.reijonen@vaisala.com>