[PATCH] firewire: cdev: Fix FW_CDEV_IOC_CREATE_ISO_CONTEXT references in kernel-doc

Karl Mehltretter posted 1 patch 1 week, 6 days ago
include/uapi/linux/firewire-cdev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] firewire: cdev: Fix FW_CDEV_IOC_CREATE_ISO_CONTEXT references in kernel-doc
Posted by Karl Mehltretter 1 week, 6 days ago
The fw_cdev_event_iso_interrupt and fw_cdev_event_iso_interrupt_mc
comments refer to FW_CDEV_CREATE_ISO_CONTEXT, but the ioctl is named
FW_CDEV_IOC_CREATE_ISO_CONTEXT.

Correct both references. The misspellings were introduced separately
with the userspace interface documentation and multichannel reception
support.

Fixes: 7ada60e36764 ("firewire: Document userspace ioctl interface.")
Fixes: 872e330e3880 ("firewire: add isochronous multichannel reception")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 include/uapi/linux/firewire-cdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/firewire-cdev.h b/include/uapi/linux/firewire-cdev.h
index 05e3aa8fa8bcbcd8e4981ef470d14fb9b941d51b..4f83d6babc92181ee969ef75b0b1b374616a3819 100644
--- a/include/uapi/linux/firewire-cdev.h
+++ b/include/uapi/linux/firewire-cdev.h
@@ -293,7 +293,7 @@ struct fw_cdev_event_request3 {
 /**
  * struct fw_cdev_event_iso_interrupt - Sent when an iso packet was completed
  * @closure:	See &fw_cdev_event_common;
- *		set by %FW_CDEV_CREATE_ISO_CONTEXT ioctl
+ *		set by %FW_CDEV_IOC_CREATE_ISO_CONTEXT ioctl
  * @type:	See &fw_cdev_event_common; always %FW_CDEV_EVENT_ISO_INTERRUPT
  * @cycle:	Cycle counter of the last completed packet
  * @header_length: Total length of following headers, in bytes
@@ -353,7 +353,7 @@ struct fw_cdev_event_iso_interrupt {
 /**
  * struct fw_cdev_event_iso_interrupt_mc - An iso buffer chunk was completed
  * @closure:	See &fw_cdev_event_common;
- *		set by %FW_CDEV_CREATE_ISO_CONTEXT ioctl
+ *		set by %FW_CDEV_IOC_CREATE_ISO_CONTEXT ioctl
  * @type:	%FW_CDEV_EVENT_ISO_INTERRUPT_MULTICHANNEL
  * @completed:	Offset into the receive buffer; data before this offset is valid
  *
Re: [PATCH] firewire: cdev: Fix FW_CDEV_IOC_CREATE_ISO_CONTEXT references in kernel-doc
Posted by Takashi Sakamoto 1 week, 6 days ago
Hi,

On Sat, Sep 12, 2026 at 12:28:07AM +0200, Karl Mehltretter wrote:
> The fw_cdev_event_iso_interrupt and fw_cdev_event_iso_interrupt_mc
> comments refer to FW_CDEV_CREATE_ISO_CONTEXT, but the ioctl is named
> FW_CDEV_IOC_CREATE_ISO_CONTEXT.
> 
> Correct both references. The misspellings were introduced separately
> with the userspace interface documentation and multichannel reception
> support.
> 
> Fixes: 7ada60e36764 ("firewire: Document userspace ioctl interface.")
> Fixes: 872e330e3880 ("firewire: add isochronous multichannel reception")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
>  include/uapi/linux/firewire-cdev.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-next branch.


Thanks

Takashi Sakamoto