[PATCH] dma-fence: Fix dma_fence_enable_signaling() reference in kernel-doc

Karl Mehltretter posted 1 patch 1 week, 6 days ago
include/linux/dma-fence.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] dma-fence: Fix dma_fence_enable_signaling() reference in kernel-doc
Posted by Karl Mehltretter 1 week, 6 days ago
The kernel-doc comment of dma_fence_is_signaled_locked() refers to
dma_fence_enable_sw_signaling, which was renamed to
dma_fence_enable_signaling by commit 9370a5c664e8 ("dma-buf: rename
dma_fence_enable_sw_signaling"). Say dma_fence_enable_signaling.

Fixes: 9370a5c664e8 ("dma-buf: rename dma_fence_enable_sw_signaling")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 include/linux/dma-fence.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
index 158cd609f1036e56668867f092041213cbf30427..3aa85be43aada5a80ea2e1cecc5f76824b434d14 100644
--- a/include/linux/dma-fence.h
+++ b/include/linux/dma-fence.h
@@ -501,7 +501,7 @@ dma_fence_test_signaled_flag(struct dma_fence *fence)
  * Returns true if the fence was already signaled, false if not. Since this
  * function doesn't enable signaling, it is not guaranteed to ever return
  * true if dma_fence_add_callback(), dma_fence_wait() or
- * dma_fence_enable_sw_signaling() haven't been called before.
+ * dma_fence_enable_signaling() haven't been called before.
  *
  * This function requires &dma_fence.lock to be held.
  *
Re: [PATCH] dma-fence: Fix dma_fence_enable_signaling() reference in kernel-doc
Posted by Christian König 1 week, 4 days ago
On 9/12/26 00:11, Karl Mehltretter wrote:
> The kernel-doc comment of dma_fence_is_signaled_locked() refers to
> dma_fence_enable_sw_signaling, which was renamed to
> dma_fence_enable_signaling by commit 9370a5c664e8 ("dma-buf: rename
> dma_fence_enable_sw_signaling"). Say dma_fence_enable_signaling.
> 
> Fixes: 9370a5c664e8 ("dma-buf: rename dma_fence_enable_sw_signaling")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

I'm really wondering why that was not automatically renamed.

Anyway reviewed and pushed to drm-misc-next.

Thanks,
Christian.

> ---
>  include/linux/dma-fence.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index 158cd609f1036e56668867f092041213cbf30427..3aa85be43aada5a80ea2e1cecc5f76824b434d14 100644
> --- a/include/linux/dma-fence.h
> +++ b/include/linux/dma-fence.h
> @@ -501,7 +501,7 @@ dma_fence_test_signaled_flag(struct dma_fence *fence)
>   * Returns true if the fence was already signaled, false if not. Since this
>   * function doesn't enable signaling, it is not guaranteed to ever return
>   * true if dma_fence_add_callback(), dma_fence_wait() or
> - * dma_fence_enable_sw_signaling() haven't been called before.
> + * dma_fence_enable_signaling() haven't been called before.
>   *
>   * This function requires &dma_fence.lock to be held.
>   *