1. Patchew
  2. linux
  3. View series

[PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable

Jaeyeon Lee posted 1 patch 2 weeks ago
There is a newer version of this series
tools/testing/selftests/mm/run_vmtests.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
Posted by Jaeyeon Lee 2 weeks ago 
The XFS setup for ./khugepaged all:file checks that the kernel supports
XFS but not that mkfs.xfs is installed. When CONFIG_XFS_FS=y and
xfsprogs is missing, mkfs.xfs and mount both fail, but
SPLIT_HUGE_PAGE_TEST_XFS_PATH is assigned from mktemp -d and stays set.
The test then runs against plain tmpfs and six subtests fail.

The script already has a skip path for this test, but it never runs
because the path variable is always set. Check that mkfs.xfs exists
before attempting the XFS setup.

Assisted-by: claude.ai:claude-opus-5
Signed-off-by: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
---
 tools/testing/selftests/mm/run_vmtests.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
index d09f9f6a384e..6315b67b6733 100755
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -415,7 +415,8 @@ CATEGORY="thp" run_test ./khugepaged -c 4 mthp_khugepaged:anon
 # Try to create XFS if not provided
 if [ -z "${SPLIT_HUGE_PAGE_TEST_XFS_PATH}" ]; then
     if test_selected "thp"; then
-	if grep xfs /proc/filesystems &>/dev/null; then
+	if grep xfs /proc/filesystems &>/dev/null &&
+	   command -v mkfs.xfs &>/dev/null; then
 	    XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
 	    SPLIT_HUGE_PAGE_TEST_XFS_PATH=$(mktemp -d /tmp/xfs_dir_XXXXXX)
 	    truncate -s 314572800 ${XFS_IMG}
-- 
2.43.0
Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
Posted by Zi Yan 1 week, 6 days ago 
On 11 Sep 2026, at 8:45, Jaeyeon Lee wrote:

> The XFS setup for ./khugepaged all:file checks that the kernel supports
> XFS but not that mkfs.xfs is installed. When CONFIG_XFS_FS=y and
> xfsprogs is missing, mkfs.xfs and mount both fail, but
> SPLIT_HUGE_PAGE_TEST_XFS_PATH is assigned from mktemp -d and stays set.
> The test then runs against plain tmpfs and six subtests fail.
>
> The script already has a skip path for this test, but it never runs
> because the path variable is always set. Check that mkfs.xfs exists
> before attempting the XFS setup.
>
> Assisted-by: claude.ai:claude-opus-5
> Signed-off-by: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>
> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index d09f9f6a384e..6315b67b6733 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -415,7 +415,8 @@ CATEGORY="thp" run_test ./khugepaged -c 4 mthp_khugepaged:anon
>  # Try to create XFS if not provided
>  if [ -z "${SPLIT_HUGE_PAGE_TEST_XFS_PATH}" ]; then
>      if test_selected "thp"; then
> -	if grep xfs /proc/filesystems &>/dev/null; then
> +	if grep xfs /proc/filesystems &>/dev/null &&
> +	   command -v mkfs.xfs &>/dev/null; then
>  	    XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
>  	    SPLIT_HUGE_PAGE_TEST_XFS_PATH=$(mktemp -d /tmp/xfs_dir_XXXXXX)
>  	    truncate -s 314572800 ${XFS_IMG}
>

This might be more robust, since it can detect mkfs.xfs and mount failures.

  if grep xfs /proc/filesystems &>/dev/null; then
      XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
      XFS_DIR=$(mktemp -d /tmp/xfs_dir_XXXXXX)
      truncate -s 314572800 ${XFS_IMG}
      if mkfs.xfs -q ${XFS_IMG} && mount -t xfs -o loop ${XFS_IMG} ${XFS_DIR}; then
          SPLIT_HUGE_PAGE_TEST_XFS_PATH=${XFS_DIR}
          MOUNTED_XFS=1
      else
          rmdir ${XFS_DIR}
          rm -f ${XFS_IMG}
      fi
  fi



Best Regards,
Yan, Zi
Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
Posted by Jaeyeon Lee 1 week, 5 days ago 
On Sat, Sep 12, 2026 at 2:06 AM Zi Yan <ziy@nvidia.com> wrote:
> This might be more robust, since it can detect mkfs.xfs and mount failures.
>
>   if grep xfs /proc/filesystems &>/dev/null; then
>       XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
>       XFS_DIR=$(mktemp -d /tmp/xfs_dir_XXXXXX)
>       truncate -s 314572800 ${XFS_IMG}
>       if mkfs.xfs -q ${XFS_IMG} && mount -t xfs -o loop ${XFS_IMG} ${XFS_DIR}; then
>           SPLIT_HUGE_PAGE_TEST_XFS_PATH=${XFS_DIR}
>           MOUNTED_XFS=1
>       else
>           rmdir ${XFS_DIR}
>           rm -f ${XFS_IMG}
>       fi
>   fi

I'll send v2 with this, adding a Suggested-by: tag and fixing the
Assisted-by: tag format.

Thanks for the review.

Best regards,
Jaeyeon Lee
Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
Posted by Lorenzo Stoakes (ARM) 2 weeks ago 
On Fri, Sep 11, 2026 at 02:45:17PM +0200, Jaeyeon Lee wrote:
> The XFS setup for ./khugepaged all:file checks that the kernel supports
> XFS but not that mkfs.xfs is installed. When CONFIG_XFS_FS=y and
> xfsprogs is missing, mkfs.xfs and mount both fail, but
> SPLIT_HUGE_PAGE_TEST_XFS_PATH is assigned from mktemp -d and stays set.
> The test then runs against plain tmpfs and six subtests fail.
>
> The script already has a skip path for this test, but it never runs
> because the path variable is always set. Check that mkfs.xfs exists
> before attempting the XFS setup.
>
> Assisted-by: claude.ai:claude-opus-5

Convention is now:

Assisted-by: LLM

See https://docs.kernel.org/process/coding-assistants.html

> Signed-off-by: Jaeyeon Lee <jaeyeon.lee.dev@gmail.com>

This seems sensible, so with the tag fixed:

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index d09f9f6a384e..6315b67b6733 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -415,7 +415,8 @@ CATEGORY="thp" run_test ./khugepaged -c 4 mthp_khugepaged:anon
>  # Try to create XFS if not provided
>  if [ -z "${SPLIT_HUGE_PAGE_TEST_XFS_PATH}" ]; then
>      if test_selected "thp"; then
> -	if grep xfs /proc/filesystems &>/dev/null; then
> +	if grep xfs /proc/filesystems &>/dev/null &&
> +	   command -v mkfs.xfs &>/dev/null; then
>  	    XFS_IMG=$(mktemp /tmp/xfs_img_XXXXXX)
>  	    SPLIT_HUGE_PAGE_TEST_XFS_PATH=$(mktemp -d /tmp/xfs_dir_XXXXXX)
>  	    truncate -s 314572800 ${XFS_IMG}
> --
> 2.43.0
>

--
Cheers, Lorenzo
Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
Posted by Andrew Morton 1 week, 6 days ago 
On Fri, 11 Sep 2026 14:01:55 +0100 "Lorenzo Stoakes (ARM)" <ljs@kernel.org> wrote:

> > Assisted-by: claude.ai:claude-opus-5
> 
> Convention is now:
> 
> Assisted-by: LLM
> 
> See https://docs.kernel.org/process/coding-assistants.html

Yeah.  That's so lame.  I like seeing what people are using - it's
interesting.

Also tautological.  What else will we ever place after
"Assisted-by: "?  Dr Watson?
Re: [PATCH] selftests/mm: skip khugepaged file tests if mkfs.xfs is unavailable
Posted by Zi Yan 1 week, 6 days ago 
On 11 Sep 2026, at 19:56, Andrew Morton wrote:

> On Fri, 11 Sep 2026 14:01:55 +0100 "Lorenzo Stoakes (ARM)" <ljs@kernel.org> wrote:
>
>>> Assisted-by: claude.ai:claude-opus-5
>>
>> Convention is now:
>>
>> Assisted-by: LLM
>>
>> See https://docs.kernel.org/process/coding-assistants.html
>
> Yeah.  That's so lame.  I like seeing what people are using - it's
> interesting.

It is like free advertising for these model[1], like I guessed.

>
> Also tautological.  What else will we ever place after
> "Assisted-by: "?  Dr Watson?

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=816d9992d9ed434ec52cfbd63080d518e535a41b

Best Regards,
Yan, Zi

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.