[PATCHv5 0/4] EDAC/altera: Address sashiko reviews part 1(v5)

Dinh Nguyen posted 4 patches 2 weeks ago
drivers/edac/altera_edac.c | 60 ++++++++++++++++++--------------------
1 file changed, 29 insertions(+), 31 deletions(-)
[PATCHv5 0/4] EDAC/altera: Address sashiko reviews part 1(v5)
Posted by Dinh Nguyen 2 weeks ago
Hi EDAC maintainers,

This is version 5 of the patch series that addresses some of the sashiko
reviews for the Altera EDAC driver.

Here's what changed:

v5: Fix a missing } in patch 3/4

v4: Rebased the series to edac-urgent branch because of patch
9868f5c077df ("EDAC/altera: Use parent device for devres in 
altr_portb_setup()") will cause conflicts.

v3: simplified commit message based on Borislav's comments

v2: reworked to only includ true sashiko hits

Thanks,
Dinh

Dinh Nguyen (4):
  EDAC/altera: Do not allow driver unbinding
  EDAC/altera: Drop __init from ECC setup paths for re-probe safety
  EDAC/altera: Fix code leak on dci allocation failure
  EDAC/altera: Fix use-after-free in error paths

 drivers/edac/altera_edac.c | 60 ++++++++++++++++++--------------------
 1 file changed, 29 insertions(+), 31 deletions(-)

-- 
2.42.0.411.g813d9a9188
Re: [PATCHv5 0/4] EDAC/altera: Address sashiko reviews part 1(v5)
Posted by Borislav Petkov 8 hours ago
On Fri, Sep 11, 2026 at 07:06:23AM -0500, Dinh Nguyen wrote:
> Dinh Nguyen (4):
>   EDAC/altera: Do not allow driver unbinding
>   EDAC/altera: Drop __init from ECC setup paths for re-probe safety
>   EDAC/altera: Fix code leak on dci allocation failure
>   EDAC/altera: Fix use-after-free in error paths

All those are marked for stable backports but the last three are fixing error
handling paths. Are they really that serious that you want to backport them
everywhere? If so, which ones?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Re: [PATCHv5 0/4] EDAC/altera: Address sashiko reviews part 1(v5)
Posted by Dinh Nguyen 22 hours ago
Ping on this series. Just wondering if there any comments for this 
series? From Boris's comments on V2[1], I thought the series is ready.

Thanks,
Dinh

[1] 
https://lore.kernel.org/all/20260814021511.GBan56L1fI-AhQ1g39@fat_crate.local/



On 9/11/26 07:06, Dinh Nguyen wrote:
> Hi EDAC maintainers,
> 
> This is version 5 of the patch series that addresses some of the sashiko
> reviews for the Altera EDAC driver.
> 
> Here's what changed:
> 
> v5: Fix a missing } in patch 3/4
> 
> v4: Rebased the series to edac-urgent branch because of patch
> 9868f5c077df ("EDAC/altera: Use parent device for devres in
> altr_portb_setup()") will cause conflicts.
> 
> v3: simplified commit message based on Borislav's comments
> 
> v2: reworked to only includ true sashiko hits
> 
> Thanks,
> Dinh
> 
> Dinh Nguyen (4):
>    EDAC/altera: Do not allow driver unbinding
>    EDAC/altera: Drop __init from ECC setup paths for re-probe safety
>    EDAC/altera: Fix code leak on dci allocation failure
>    EDAC/altera: Fix use-after-free in error paths
> 
>   drivers/edac/altera_edac.c | 60 ++++++++++++++++++--------------------
>   1 file changed, 29 insertions(+), 31 deletions(-)
>
Re: [PATCHv5 0/4] EDAC/altera: Address sashiko reviews part 1(v5)
Posted by Borislav Petkov 8 hours ago
On Thu, Sep 24, 2026 at 09:48:47AM -0500, Dinh Nguyen wrote:
> Ping on this series. Just wondering if there any comments for this series?
> From Boris's comments on V2[1], I thought the series is ready.

They're on the todo list.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette