[PATCH] rcu: Drop the private tick-internal.h include from tree.c

Bradley Morgan posted 1 patch 2 weeks ago
kernel/rcu/tree.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] rcu: Drop the private tick-internal.h include from tree.c
Posted by Bradley Morgan 2 weeks ago
Nothing in the tree.c translation unit uses anything from the
private timekeeping header ../time/tick-internal.h, included
since commit 48d07c04b4cc ("rcu: Enable elimination of
Tree-RCU softirq processing"). The tick symbols RCU uses,
tick_dep_set(), tick_dep_clear(), their _cpu and _task
variants, tick_nohz_full_cpu() and TICK_DEP_BIT_RCU, are all
declared in the public linux/tick.h, which tree.c already
includes.

Drop the include.

Signed-off-by: Bradley Morgan <brads@mainlining.org>
---
 kernel/rcu/tree.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 96848fc1f02b..338737b9781c 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -64,7 +64,6 @@
 #include <linux/mm.h>
 #include <linux/kasan.h>
 #include <linux/context_tracking.h>
-#include "../time/tick-internal.h"
 
 #include "tree.h"
 #include "rcu.h"
-- 
2.47.3
Re: [PATCH] rcu: Drop the private tick-internal.h include from tree.c
Posted by Paul E. McKenney 2 weeks ago
On Thu, Sep 10, 2026 at 05:25:37PM +0000, Bradley Morgan wrote:
> Nothing in the tree.c translation unit uses anything from the
> private timekeeping header ../time/tick-internal.h, included
> since commit 48d07c04b4cc ("rcu: Enable elimination of
> Tree-RCU softirq processing"). The tick symbols RCU uses,
> tick_dep_set(), tick_dep_clear(), their _cpu and _task
> variants, tick_nohz_full_cpu() and TICK_DEP_BIT_RCU, are all
> declared in the public linux/tick.h, which tree.c already
> includes.
> 
> Drop the include.
> 
> Signed-off-by: Bradley Morgan <brads@mainlining.org>

Applied for testing and additional review, thank you!

							Thanx, Paul

> ---
>  kernel/rcu/tree.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 96848fc1f02b..338737b9781c 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -64,7 +64,6 @@
>  #include <linux/mm.h>
>  #include <linux/kasan.h>
>  #include <linux/context_tracking.h>
> -#include "../time/tick-internal.h"
>  
>  #include "tree.h"
>  #include "rcu.h"
> -- 
> 2.47.3