[PATCH net-next] selftests: netdevsim: add TEST_INCLUDES to Makefile

Hangbin Liu posted 1 patch 2 weeks, 1 day ago
tools/testing/selftests/drivers/net/netdevsim/Makefile | 8 ++++++++
1 file changed, 8 insertions(+)
[PATCH net-next] selftests: netdevsim: add TEST_INCLUDES to Makefile
Posted by Hangbin Liu 2 weeks, 1 day ago
From: Hangbin Liu <liuhangbin@kylinos.cn>

Some netdevsim selftests source forwarding/lib.sh and other files, but
the Makefile doesn't have TEST_INCLUDES targets, which makes

  make INSTALL_PATH=/tmp/kself TARGETS=drivers/net/netdevsim \
     -C tools/testing/selftests install

failed to install related lib files. Add TEST_INCLUDES to the Makefile
to install the dependencies.

Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
---
As there are multi nsim selftests include the lib.sh but no error report
for the installation issue. So I won't bother fixes tags and just post
this patch to net-next.
---
 tools/testing/selftests/drivers/net/netdevsim/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/testing/selftests/drivers/net/netdevsim/Makefile b/tools/testing/selftests/drivers/net/netdevsim/Makefile
index 9808c2fbae9e..bb90fe89d9a1 100644
--- a/tools/testing/selftests/drivers/net/netdevsim/Makefile
+++ b/tools/testing/selftests/drivers/net/netdevsim/Makefile
@@ -22,4 +22,12 @@ TEST_FILES := \
 	ethtool-common.sh
 # end of TEST_FILES
 
+TEST_INCLUDES := \
+	$(wildcard ../../../net/lib/sh/*.sh) \
+	../../../net/forwarding/devlink_lib.sh \
+	../../../net/forwarding/fib_offload_lib.sh \
+	../../../net/forwarding/lib.sh \
+	../../../net/lib.sh \
+# end of TEST_INCLUDES
+
 include ../../../lib.mk

---
base-commit: 63487bb38a97918656751a2a4b74809bbe22eacb
change-id: 20260910-nsim_lib-489cd5abf074

Best regards,
-- 
Hangbin Liu <liuhangbin@kylinos.cn>
Re: [PATCH net-next] selftests: netdevsim: add TEST_INCLUDES to Makefile
Posted by Simon Horman 2 weeks ago
On Thu, Sep 10, 2026 at 04:06:58PM +0800, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
> 
> Some netdevsim selftests source forwarding/lib.sh and other files, but
> the Makefile doesn't have TEST_INCLUDES targets, which makes
> 
>   make INSTALL_PATH=/tmp/kself TARGETS=drivers/net/netdevsim \
>      -C tools/testing/selftests install
> 
> failed to install related lib files. Add TEST_INCLUDES to the Makefile
> to install the dependencies.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
> ---
> As there are multi nsim selftests include the lib.sh but no error report
> for the installation issue. So I won't bother fixes tags and just post
> this patch to net-next.

Reviewed-by: Simon Horman <horms@kernel.org>