[PATCH] net: ipconfig: use ifreq field aliases

Lalit Shankar Chowdhury posted 1 patch 2 weeks, 2 days ago
net/ipv4/ipconfig.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] net: ipconfig: use ifreq field aliases
Posted by Lalit Shankar Chowdhury 2 weeks, 2 days ago
Use the ifr_addr and ifr_name macros instead of the lengthier versions.

Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
---
 net/ipv4/ipconfig.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 155db067eaec..475393a86c91 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -367,11 +367,11 @@ set_sockaddr(struct sockaddr_in *sin, __be32 addr, __be16 port)
 static int __init ic_setup_if(void)
 {
 	struct ifreq ir;
-	struct sockaddr_in *sin = (void *) &ir.ifr_ifru.ifru_addr;
+	struct sockaddr_in *sin = (void *) &ir.ifr_addr;
 	int err;
 
 	memset(&ir, 0, sizeof(ir));
-	strcpy(ir.ifr_ifrn.ifrn_name, ic_dev->dev->name);
+	strcpy(ir.ifr_name, ic_dev->dev->name);
 	set_sockaddr(sin, ic_myaddr, 0);
 	if ((err = devinet_ioctl(&init_net, SIOCSIFADDR, &ir)) < 0) {
 		pr_err("IP-Config: Unable to set interface address (%d)\n",
-- 
2.53.0
Re: [PATCH] net: ipconfig: use ifreq field aliases
Posted by Stephen Hemminger 2 weeks ago
On Wed,  9 Sep 2026 14:44:16 +0000
Lalit Shankar Chowdhury <lalitshankarch@gmail.com> wrote:

> Use the ifr_addr and ifr_name macros instead of the lengthier versions.
> 
> Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
> ---

Why? seems like useless churn. Those header files never change
Re: [PATCH] net: ipconfig: use ifreq field aliases
Posted by Ido Schimmel 2 weeks, 1 day ago
On Wed, Sep 09, 2026 at 02:44:16PM +0000, Lalit Shankar Chowdhury wrote:
> Use the ifr_addr and ifr_name macros instead of the lengthier versions.

Please read the following document before submitting more networking
patches:

https://docs.kernel.org/next/process/maintainer-netdev.html

In particular:

https://docs.kernel.org/next/process/maintainer-netdev.html#clean-up-patches

Thanks