Documentation/gpu/nova/core/todo.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Add missing ')'.
Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
---
Documentation/gpu/nova/core/todo.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/gpu/nova/core/todo.rst b/Documentation/gpu/nova/core/todo.rst
index d5130b2b0..a01c362b1 100644
--- a/Documentation/gpu/nova/core/todo.rst
+++ b/Documentation/gpu/nova/core/todo.rst
@@ -33,7 +33,7 @@ A good example from nova-core would be the ``Chipset`` enum type, which defines
the value ``AD102``. When probing the GPU the value ``0x192`` can be read from a
certain register indication the chipset AD102. Hence, the enum value ``AD102``
should be derived from the number ``0x192``. Currently, nova-core uses a custom
-implementation (``Chipset::from_u32`` for this.
+implementation (``Chipset::from_u32``) for this.
Instead, it would be desirable to have something like the ``FromPrimitive``
trait [1] from the num crate.
--
2.54.0
On Wed, 09 Sep 2026 15:53:19 +0200, Manuel Ebner wrote:
> Add missing ')'.
Applied to drm-rust-next, thanks!
[1/1] Documentation nova: Fix bracket
[acourbot: add missing `:` in commit title]
commit: 66a2c223b620d844fe26c6bd4844d2a6a8c9dffc
On 9/9/26 6:53 AM, Manuel Ebner wrote: > Add missing ')'. > > Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org> Acked-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > Documentation/gpu/nova/core/todo.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/gpu/nova/core/todo.rst b/Documentation/gpu/nova/core/todo.rst > index d5130b2b0..a01c362b1 100644 > --- a/Documentation/gpu/nova/core/todo.rst > +++ b/Documentation/gpu/nova/core/todo.rst > @@ -33,7 +33,7 @@ A good example from nova-core would be the ``Chipset`` enum type, which defines > the value ``AD102``. When probing the GPU the value ``0x192`` can be read from a > certain register indication the chipset AD102. Hence, the enum value ``AD102`` > should be derived from the number ``0x192``. Currently, nova-core uses a custom > -implementation (``Chipset::from_u32`` for this. > +implementation (``Chipset::from_u32``) for this. > > Instead, it would be desirable to have something like the ``FromPrimitive`` > trait [1] from the num crate. -- ~Randy
© 2016 - 2026 Red Hat, Inc.