[PATCH] svcrdma: Fix svc_rdma_recv_cid_init() kernel-doc

Karl Mehltretter posted 1 patch 2 weeks, 2 days ago
include/linux/sunrpc/svc_rdma.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] svcrdma: Fix svc_rdma_recv_cid_init() kernel-doc
Posted by Karl Mehltretter 2 weeks, 2 days ago
svc_rdma_recv_cid_init() initializes a Receive Queue completion ID,
but its kernel-doc heading names svc_rdma_send_cid_init(). The latter is
a separate helper immediately below it, so kernel-doc cannot match this
comment to the receive helper.

Fix the copied function name.

Fixes: 28ee0ec8948a ("svcrdma: De-duplicate completion ID initialization helpers")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 include/linux/sunrpc/svc_rdma.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
index 76aa5ec4ab40..5ccb13bf906f 100644
--- a/include/linux/sunrpc/svc_rdma.h
+++ b/include/linux/sunrpc/svc_rdma.h
@@ -142,7 +142,7 @@ enum {
 #define RPCSVC_MAXPAYLOAD_RDMA	RPCSVC_MAXPAYLOAD
 
 /**
- * svc_rdma_send_cid_init - Initialize a Receive Queue completion ID
+ * svc_rdma_recv_cid_init - Initialize a Receive Queue completion ID
  * @rdma: controlling transport
  * @cid: completion ID to initialize
  */

base-commit: 893e11787f78e43b534e252249ac3fff4d1333f8
-- 
2.53.0
Re: [PATCH] svcrdma: Fix svc_rdma_recv_cid_init() kernel-doc
Posted by Chuck Lever 2 weeks, 2 days ago
On Wed, 09 Sep 2026 08:43:43 +0200, Karl Mehltretter wrote:
> svc_rdma_recv_cid_init() initializes a Receive Queue completion ID,
> but its kernel-doc heading names svc_rdma_send_cid_init(). The latter is
> a separate helper immediately below it, so kernel-doc cannot match this
> comment to the receive helper.
> 
> Fix the copied function name.
> 
> [...]

Applied to nfsd-testing, thanks!

[1/1] svcrdma: Fix svc_rdma_recv_cid_init() kernel-doc
      (no commit info)

--
Chuck Lever